From f6387fc08f146a18cf66dbba5589c860843663d4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Franti=C5=A1ek=20Dvo=C5=99=C3=A1k?= <valtri@civ.zcu.cz>
Date: Tue, 16 Jul 2024 21:12:58 +0000
Subject: [PATCH] b2drop: disable storing secrets in the JupyterHub database
---
cesnet-central/deployments/fullhub.yaml | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/cesnet-central/deployments/fullhub.yaml b/cesnet-central/deployments/fullhub.yaml
index 144b2ab..decfbd2 100644
--- a/cesnet-central/deployments/fullhub.yaml
+++ b/cesnet-central/deployments/fullhub.yaml
@@ -184,7 +184,6 @@ hub:
await super(B2DropSpawner, self).pre_spawn_hook(spawner)
b2drop_user = self.user_options.get("b2drop-user", "")
b2drop_pwd = self.user_options.get("b2drop-pwd", "")
- b2drop_remember = self.user_options.get("b2drop-remember", None)
if not (b2drop_user and b2drop_pwd):
secret = await self.api.read_namespaced_secret(self.token_secret_name, self.namespace)
if secret and secret.data:
@@ -217,16 +216,10 @@ hub:
"volumeMounts": volume_mounts,
}
)
- if b2drop_remember:
- await self._update_secret({"b2drop-user": b2drop_user,
- "b2drop-pwd": b2drop_pwd})
- else:
- await self._update_secret({"b2drop-user": "", "b2drop-pwd": ""})
def options_from_form(self, formdata):
data = super(B2DropSpawner, self)._options_from_form(formdata)
data.update({'b2drop-user': formdata.get('b2drop-user', [None])[0],
- 'b2drop-remember': formdata.get('b2drop-remember', [None])[0],
'b2drop-pwd': formdata.get('b2drop-pwd', [None])[0]})
return data
@@ -415,10 +408,6 @@ hub:
<label for="b2drop-pwd" class="form-label">B2DROP app Password</label>
<input type="password" class="form-control" name="b2drop-pwd" id="b2drop-pwd" value="{{ b2drop_pwd }}">
</div>
- <div class='form-group'>
- <input type="checkbox" id="b2drop-remember" name="b2drop-remember" {%if b2drop_ready %}checked{% endif %}>
- <label class="form-check-label" for="from-check-input">Remember B2DROP credentials</label>
- </div>
</div>
</div>
</div>
--
GitLab