From aa40cd9c7172384edab885ad475a1e7831a57637 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rajmund=20Hru=C5=A1ka?= <rajmund.hruska@cesnet.cz> Date: Fri, 2 May 2025 10:11:22 +0200 Subject: [PATCH] Refactor: Simplify short-circuit evaluation --- ransack/transformer.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/ransack/transformer.py b/ransack/transformer.py index 08916a1..1b148dc 100644 --- a/ransack/transformer.py +++ b/ransack/transformer.py @@ -634,10 +634,7 @@ class Filter(Interpreter): Returns: True if either subtree evaluates to True, otherwise False. """ - if (left := self.visit(l_tree)) is True: - return True - right = self.visit(r_tree) - return left or right + return self.visit(l_tree) or self.visit(r_tree) def and_op(self, l_tree: Tree, r_tree: Tree) -> bool: """ @@ -652,10 +649,7 @@ class Filter(Interpreter): Returns: True if both subtrees evaluate to True, otherwise False. """ - if (left := self.visit(l_tree)) is False: - return False - right = self.visit(r_tree) - return left and right + return self.visit(l_tree) and self.visit(r_tree) def not_op(self, tree: Tree) -> bool: """ -- GitLab