diff --git a/src/warden-server/bin/getClients.pl b/src/warden-server/bin/getClients.pl index ff64ec2eabf7891ae940357bbdd639223330f8d2..1649ed25d6a908f6c4e8186cd2ec017cb434dc2d 100755 --- a/src/warden-server/bin/getClients.pl +++ b/src/warden-server/bin/getClients.pl @@ -74,7 +74,7 @@ if ($script_version) { } # connect to DB -my $dbh = WardenCommon::connectDB($WardenCommon::DB_NAME, $WardenCommon::DB_HOST, $WardenCommon::DB_USER, $WardenCommon::DB_PASS); +my $dbh = WardenCommon::connectDB; # obtain data from DB my $sth = $dbh->prepare("SELECT * FROM clients ORDER BY client_id ASC;") or die "Cannot prepare statement: " . $dbh->errstr; diff --git a/src/warden-server/bin/getStatus.pl b/src/warden-server/bin/getStatus.pl index 9eec8a7f02972f329b4bb94633fb19d1319fe8a3..dcf5da1206452e4ab0c821ae571a9bc2b3c2d89d 100755 --- a/src/warden-server/bin/getStatus.pl +++ b/src/warden-server/bin/getStatus.pl @@ -76,7 +76,7 @@ if ($script_version) { } # connect to DB -my $dbh = WardenCommon::connectDB($WardenCommon::DB_NAME, $WardenCommon::DB_HOST, $WardenCommon::DB_USER, $WardenCommon::DB_PASS); +my $dbh = WardenCommon::connectDB; #----------------------------------------------------------------------------- # Warden server variables diff --git a/src/warden-server/bin/registerReceiver.pl b/src/warden-server/bin/registerReceiver.pl index 166ed62cb556d1abda7dc1e7f0720771f73d3e03..bbf828dc5f7e4c319407ccc6bcbf8f29cd4ccf8c 100755 --- a/src/warden-server/bin/registerReceiver.pl +++ b/src/warden-server/bin/registerReceiver.pl @@ -131,7 +131,7 @@ my $description_tags = undef; my $warden_server = WardenCommon::trim(`hostname -f`); # connect to DB -my $dbh = WardenCommon::connectDB($WardenCommon::DB_NAME, $WardenCommon::DB_HOST, $WardenCommon::DB_USER, $WardenCommon::DB_PASS); +my $dbh = WardenCommon::connectDB; # register receiver my ($sth, $client_id_db, $hostname_db, $registered_db, $requestor_db, $client_type_db, $type_db, $receive_own_events_db, $ip_net_client_db, $valid_db); diff --git a/src/warden-server/bin/registerSender.pl b/src/warden-server/bin/registerSender.pl index a245168a9f034a88e7bf93b7463254ae5a2f2f4e..ddde45c4aee0334b3eec2260961023720bbf112e 100755 --- a/src/warden-server/bin/registerSender.pl +++ b/src/warden-server/bin/registerSender.pl @@ -123,7 +123,7 @@ my $receive_own_events = undef; my $warden_server = WardenCommon::trim(`hostname -f`); # connect to DB -my $dbh = WardenCommon::connectDB($WardenCommon::DB_NAME, $WardenCommon::DB_HOST, $WardenCommon::DB_USER, $WardenCommon::DB_PASS); +my $dbh = WardenCommon::connectDB; # register sender my ($sth, $client_id_db, $hostname_db, $registered_db, $requestor_db, $service_db, $client_type_db, $description_tags_db, $ip_net_client_db, $valid_db); diff --git a/src/warden-server/bin/unregisterClient.pl b/src/warden-server/bin/unregisterClient.pl index c23ec2e407d9308ae9a6a3c2a018a645c8a8b8f2..7d9cfa094b0ad9def99da9803eec73be51f335d9 100755 --- a/src/warden-server/bin/unregisterClient.pl +++ b/src/warden-server/bin/unregisterClient.pl @@ -91,7 +91,7 @@ if ($client_id !~ /^\d+\z/) { } # connect to DB -my $dbh = WardenCommon::connectDB($WardenCommon::DB_NAME, $WardenCommon::DB_HOST, $WardenCommon::DB_USER, $WardenCommon::DB_PASS); +my $dbh = WardenCommon::connectDB; # obtain a server hostname my $warden_server = WardenCommon::trim(`hostname -f`); diff --git a/src/warden-server/lib/Warden.pm b/src/warden-server/lib/Warden.pm index 64156530e28aff878398fb7d0e84d50be417fd0b..1be06f60ff1b43ddead3c0245e1154fd776f85af 100755 --- a/src/warden-server/lib/Warden.pm +++ b/src/warden-server/lib/Warden.pm @@ -48,8 +48,7 @@ WardenCommon::loadConf($conf_file); # DB CONNECT ################################################################################ # create database handler -our $DBH = DBI->connect("DBI:mysql:database=$WardenCommon::DB_NAME;host=$WardenCommon::DB_HOST", $WardenCommon::DB_USER, $WardenCommon::DB_PASS, {RaiseError => 1, mysql_auto_reconnect => 1}) - || die "Could not connect to database '$WardenCommon::DB_NAME' at '$WardenCommon::DB_HOST': $DBI::errstr"; +our $DBH = WardenCommon::connectDB; diff --git a/src/warden-server/lib/WardenCommon.pm b/src/warden-server/lib/WardenCommon.pm index 60ac19e8431cbf82cfe08496d0782a5e394e6c06..9970b666230ce2145c5ebb86d535c633f5b4256a 100755 --- a/src/warden-server/lib/WardenCommon.pm +++ b/src/warden-server/lib/WardenCommon.pm @@ -106,12 +106,7 @@ sub loadConf #------------------------------------------------------------------------------- sub connectDB { - my $db_name = shift; - my $db_host = shift; - my $db_user = shift; - my $db_pass = shift; - - my $dbh = DBI->connect("DBI:mysql:database=$db_name;host=$db_host",$db_user, $db_pass, {RaiseError => 1, mysql_auto_reconnect => 1}) || die "Could not connect to database '$db_name' at '$db_host': $DBI::errstr"; + my $dbh = DBI->connect("DBI:mysql:database=$WardenCommon::DB_NAME;host=$WardenCommon::DB_HOST",$WardenCommon::DB_USER, $WardenCommon::DB_PASS, {RaiseError => 1, mysql_auto_reconnect => 1}) || die "Could not connect to database '$WardenCommon::DB_NAME' at '$WardenCommon::DB_HOST': $DBI::errstr"; return $dbh; } # End of connectDB