From 3691bca31bdfedafd8083f9a09c569020b22d7b2 Mon Sep 17 00:00:00 2001
From: Tomas Plesnik <plesnik@ics.muni.cz>
Date: Tue, 28 Feb 2012 15:05:06 +0100
Subject: [PATCH] odstraneni nadbytecnych promennych ret_val; revize kodu

---
 packages/build-client.sh          | 81 +++++---------------------
 packages/build-server.sh          | 97 ++++++-------------------------
 src/warden-client/sh/install.sh   | 18 ++----
 src/warden-client/sh/uninstall.sh |  6 +-
 src/warden-client/sh/update.sh    | 18 ++----
 src/warden-server/sh/uninstall.sh | 13 ++---
 6 files changed, 53 insertions(+), 180 deletions(-)

diff --git a/packages/build-client.sh b/packages/build-client.sh
index f8c129a..5e176f4 100755
--- a/packages/build-client.sh
+++ b/packages/build-client.sh
@@ -66,97 +66,48 @@ echo "Building $package_name package version $version ..."
 echo
 
 echo -n "Building 'base' directory ... "
-mkdir -p $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/sh/* $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/CHANGELOG $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/INSTALL $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/LICENSE $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/README $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/README.cesnet $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-
+mkdir -p $package 2> $err || err
+cp -R ../src/$package_name/sh/* $package 2> $err || err
+cp ../src/$package_name/doc/CHANGELOG $package 2> $err || err
+cp ../src/$package_name/doc/INSTALL $package 2> $err || err
+cp ../src/$package_name/doc/LICENSE $package 2> $err || err
+cp ../src/$package_name/doc/README $package 2> $err || err
+cp ../src/$package_name/doc/README.cesnet $package 2> $err || err
 echo "OK"
 
 
 echo -n "Building '$doc' directory ... "
-mkdir -p $doc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/doc/* $doc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $doc 2> $err || err
+cp -R ../src/$package_name/doc/* $doc 2> $err || err
 echo "OK"
 
 
 echo -n "Building '$etc' directory ... "
-mkdir -p $etc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/etc/package_version $etc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $etc 2> $err || err
+cp ../src/$package_name/etc/package_version $etc 2> $err || err
 echo "OK"
 
 
 echo -n "Building '$lib' directory ... "
-mkdir -p $lib 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/lib/* $lib 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $lib 2> $err || err
+cp -R ../src/$package_name/lib/* $lib 2> $err || err
 echo "OK"
 
 
 echo -n "Building '$var' directory ... "
-mkdir -p $var 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $var 2> $err || err
 echo "OK"
 
 
 # create tarball
 echo -n "Creating $tar tarball ... "
-tar czf $tar $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+tar czf $tar $package 2> $err || err
 echo "OK"
 
 
 # create sign of tarball
 echo -n "Creating $sig file ... "
-sha1sum $tar > $sig 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+sha1sum $tar > $sig 2> $err || err
 echo "OK"
 
 
diff --git a/packages/build-server.sh b/packages/build-server.sh
index 75a7f2b..3b7be0c 100755
--- a/packages/build-server.sh
+++ b/packages/build-server.sh
@@ -67,109 +67,50 @@ echo "Building $package_name package version $version ..."
 echo
 
 echo -n "Building 'base' directory ... "
-mkdir -p $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/sh/install.sh $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/sh/uninstall.sh $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/CHANGELOG $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/INSTALL $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/LICENSE $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/doc/README $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $package 2> $err || err
+cp ../src/$package_name/sh/install.sh $package 2> $err || err
+cp ../src/$package_name/sh/uninstall.sh $package 2> $err || err
+cp ../src/$package_name/doc/CHANGELOG $package 2> $err || err
+cp ../src/$package_name/doc/INSTALL $package 2> $err || err
+cp ../src/$package_name/doc/LICENSE $package 2> $err || err
+cp ../src/$package_name/doc/README $package 2> $err || err
 echo "OK"
 
 echo -n "Building '$bin' directory ... "
-mkdir -p $bin 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/bin/* $bin 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/sh/create_tables.sh $bin 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $bin 2> $err || err
+cp -R ../src/$package_name/bin/* $bin 2> $err || err
+cp -R ../src/$package_name/sh/create_tables.sh $bin 2> $err || err
 echo "OK"
 
 echo -n "Building '$doc' directory ... "
-mkdir -p $doc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/doc/* $doc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $doc 2> $err || err
+cp -R ../src/$package_name/doc/* $doc 2> $err || err
 echo "OK"
 
 echo -n "Building '$etc' directory ... "
-mkdir -p $etc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp ../src/$package_name/etc/package_version $etc 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $etc 2> $err || err
+cp ../src/$package_name/etc/package_version $etc 2> $err || err
 echo "OK"
 
-
 echo -n "Building '$lib' directory ... "
-mkdir -p $lib 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
-cp -R ../src/$package_name/lib/* $lib 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $lib 2> $err || err
+cp -R ../src/$package_name/lib/* $lib 2> $err || err
 echo "OK"
 
-
 echo -n "Building '$var' directory ... "
-mkdir -p $var 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+mkdir -p $var 2> $err || err
 echo "OK"
 
 
 # create tarball
 echo -n "Creating $tar tarball ... "
-tar czf $tar $package 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+tar czf $tar $package 2> $err || err
 echo "OK"
 
 
 #  create sign of tarball
 echo -n "Creating $sig file ... "
-sha1sum $tar > $sig 2> $err; ret_val=`echo $?`
-if [ $ret_val -ne 0 ]; then
-  err
-fi
+sha1sum $tar > $sig 2> $err || err
 echo "OK"
 
 
diff --git a/src/warden-client/sh/install.sh b/src/warden-client/sh/install.sh
index 726318b..d415fbe 100755
--- a/src/warden-client/sh/install.sh
+++ b/src/warden-client/sh/install.sh
@@ -156,8 +156,7 @@ old_client_chck()
 perl_chck()
 {
 	echo -n "Checking Perl interpreter ... "
-	which perl 1>/dev/null; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if which perl 1> /dev/null; then
 		echo "OK"
 	else
 		echo "FAILED!"
@@ -172,8 +171,7 @@ modules_chck()
 	for module in ${modules[@]};
 	do
 		echo -n "Checking $module module ... "
-		perl -e "use $module" 2> $err; ret_val=`echo $?`
-		if [ $ret_val -eq 0 ]; then
+		if perl -e "use $module" 2> $err; then
 			echo "OK"
 		else
 			err
@@ -185,8 +183,7 @@ modules_chck()
 make_warden_dir()
 {
 	echo -n "Creating warden client directory ... "
-	cp -R $dirname/warden-client $prefix 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if cp -R $dirname/warden-client $prefix 2> $err; then
 		echo "OK"
 	else
 		err_clean
@@ -204,8 +201,7 @@ make_warden_dir()
 copy_key()
 {
 	echo -n "Copying certificate key file ... "
-	cp $key $etc 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if cp $key $etc 2> $err; then
 		echo "OK"
 	else
 		err_clean
@@ -216,8 +212,7 @@ copy_key()
 copy_cert()
 {
 	echo -n "Copying certificate file ... "
-	cp $cert $etc 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if cp $cert $etc 2> $err; then
 		echo "OK"
 	else
 		err_clean
@@ -264,8 +259,7 @@ make_conf_file()
 change_permissions()
 {
 	echo -n "Changing permissions to installed package ... "
-	chown -R $user: $client_path 2>$err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if chown -R $user: $client_path 2>$err; then
 		echo "OK"
 	else
 		err_clean
diff --git a/src/warden-client/sh/uninstall.sh b/src/warden-client/sh/uninstall.sh
index bb4cc9b..98342e8 100755
--- a/src/warden-client/sh/uninstall.sh
+++ b/src/warden-client/sh/uninstall.sh
@@ -149,8 +149,7 @@ backup()
 {
 	echo -n "Backing-up warden client directory ... "
 	mkdir $backup_dir
-	cp -R $client_path $backup_dir 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if cp -R $client_path $backup_dir 2> $err; then
 		echo "OK"
 	else
 		err
@@ -161,8 +160,7 @@ backup()
 uninstall_warden_client()
 {
 	echo -n "Uninstalling $package_version package ... "
-	rm -rf $client_path 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if rm -rf $client_path 2> $err; then
 		echo "OK"
 	else
 		err_clean
diff --git a/src/warden-client/sh/update.sh b/src/warden-client/sh/update.sh
index 200e1c6..ea49b3e 100755
--- a/src/warden-client/sh/update.sh
+++ b/src/warden-client/sh/update.sh
@@ -143,8 +143,7 @@ obtain_package_version()
 perl_chck()
 {
 	echo -n "Checking Perl interpreter ... "
-	which perl 1>/dev/null; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if which perl 1> /dev/null; then
 		echo "OK"
 	else
 		echo "FAILED!"
@@ -159,8 +158,7 @@ modules_chck()
 	for module in ${modules[@]};
 	do
 		echo -n "Checking $module module ... "
-		perl -e "use $module" 2> $err; ret_val=`echo $?`
-		if [ $ret_val -eq 0 ]; then
+		if perl -e "use $module" 2> $err; then
 			echo "OK"
 		else
 			err
@@ -186,8 +184,7 @@ backup()
 {
 	echo -n "Backing-up warden client directory ... "
 	mkdir $backup_dir
-	cp -R $client_path $backup_dir 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if cp -R $client_path $backup_dir 2> $err; then
 		echo "OK"
 	else
 		err
@@ -198,8 +195,7 @@ backup()
 obtain_warden_user()
 {
 	echo -n "Obtaining warden client directory owner ... "
-	user=`stat -c %U $conf_file` 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if user=`stat -c %U $conf_file` 2> $err; then
 		echo "OK"
 	else
 		err
@@ -210,8 +206,7 @@ obtain_warden_user()
 update_warden_dir()
 {
 	echo -n "Updating warden client directory ... "
-	rsync -q --recursive --archive --delete	--exclude='etc' --exclude='var' "$dirname/warden-client" $prefix 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if rsync -q --recursive --archive --delete --exclude='etc' --exclude='var' "$dirname/warden-client" $prefix 2> $err; then
 		echo "OK"
 	else
 		err_clean
@@ -270,8 +265,7 @@ $ssl_ca_file
 change_permissions()
 {
 	echo -n "Changing permissions to updated package ... "
-	chown -R $user: $client_path 2>$err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if chown -R $user: $client_path 2>$err; then
 		echo "OK"
 	else
 		err_clean
diff --git a/src/warden-server/sh/uninstall.sh b/src/warden-server/sh/uninstall.sh
index ec773f1..b6f9ab6 100755
--- a/src/warden-server/sh/uninstall.sh
+++ b/src/warden-server/sh/uninstall.sh
@@ -148,11 +148,8 @@ warden_dir_chck()
 
 stop_warden_server()
 {
-	$init stop
-	ret_val=`$init status | grep NOT; echo $?`
-	if [$ret_val -ne 0]; then
-		$init force-stop
-	fi
+	echo "Stopping warden server ... "
+	$init stop || $init force-stop
 }
 
 
@@ -160,8 +157,7 @@ backup()
 {
 	echo -n "Backing-up warden server directory ... "
 	mkdir $backup_dir
-	cp -R $server_path $backup_dir 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if cp -R $server_path $backup_dir 2> $err; then
 		echo "OK"
 	else
 		err
@@ -172,8 +168,7 @@ backup()
 uninstall_warden_server()
 {
 	echo -n "Uninstalling $package_version package ... "
-	rm -rf $server_path 2> $err; ret_val=`echo $?`
-	if [ $ret_val -eq 0 ]; then
+	if rm -rf $server_path 2> $err; then
 		echo "OK"
 	else
 		err_clean
-- 
GitLab