diff --git a/warden3/warden_client/warden_client.py b/warden3/warden_client/warden_client.py index cdcec00d51f66cb623b3db1fa3f836b44736d988..04c851530129d22b4762fdb766fe5cd58359b794 100644 --- a/warden3/warden_client/warden_client.py +++ b/warden3/warden_client/warden_client.py @@ -425,20 +425,23 @@ class Client(object): else: argurl = "" - try: - if payload is None: - data = "" - else: + self.headers = {"Accept": "application/json"} + data = None + + if payload is None: + method = "GET" + else: + method = "POST" + try: data = json.dumps(payload) - except: - return Error(message="Serialization to JSON failed", - exc=exc_info(), method=func, payload=payload) + except: + return Error(message="Serialization to JSON failed", + exc=exc_info(), method=func, payload=payload) - self.headers = { - "Content-Type": "application/json", - "Accept": "application/json", - "Content-Length": str(len(data)) - } + self.headers.update({ + "Content-Type": "application/json", + "Content-Length": str(len(data)) + }) # HTTP(S)Connection is oneshot object (and we don't speak "pipelining") conn = self.connect() @@ -447,7 +450,7 @@ class Client(object): loc = '%s/%s%s' % (self.url.path, func, argurl) try: - conn.request("POST", loc, data, self.headers) + conn.request(method, loc, data, self.headers) except: conn.close() return Error(message="Sending of request to server failed", diff --git a/warden3/warden_client/warden_curl_test.sh b/warden3/warden_client/warden_curl_test.sh index 71dfbc2cb8bfd5ddf1514a81e68f0df223e909d3..d1a4405258d95c9966bf97ad76bbd31fca52866e 100755 --- a/warden3/warden_client/warden_curl_test.sh +++ b/warden3/warden_client/warden_curl_test.sh @@ -23,7 +23,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/blefub?client=$client&secret=$secret" echo @@ -33,7 +32,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/?client=$client&secret=$secret" echo @@ -43,7 +41,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client" echo @@ -53,7 +50,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents" echo @@ -63,7 +59,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=asdf.blefub" echo @@ -73,7 +68,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=asdf.blefub&secret=$secret" echo @@ -83,7 +77,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=ASDFblefub" echo @@ -93,7 +86,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?secret=$secret" echo @@ -114,7 +106,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=$secret&cat=bflm" echo @@ -124,7 +115,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=$secret&cat=Other&nocat=Test" echo @@ -145,7 +135,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=$secret&self=test" echo @@ -155,7 +144,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=$secret&bad=guy" echo @@ -165,7 +153,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=$secret" echo @@ -175,7 +162,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getEvents?client=$client&secret=$secret&count=3&id=10" echo @@ -185,7 +171,6 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getDebug?client=$client&secret=$secret" echo @@ -195,6 +180,5 @@ curl \ --cert $certfile \ --cacert $cafile \ --connect-timeout 3 \ - --request POST \ "$url/getInfo?client=$client&secret=$secret" echo