From 18be09e9d5743893347cd83864bc9c2936e44a8e Mon Sep 17 00:00:00 2001 From: Alexander Rose <alexander.rose@weirdbyte.de> Date: Wed, 12 Apr 2023 23:28:16 -0700 Subject: [PATCH] fix .getAllLoci for representations with structure.child --- CHANGELOG.md | 1 + src/mol-repr/structure/complex-representation.ts | 2 +- src/mol-repr/structure/units-representation.ts | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c80c7cdc6..3d3a2720b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ Note that since we don't clearly distinguish between a public and private interf - Add "Zoom All", "Orient Axes", "Reset Axes" buttons to the "Reset Camera" button - Improve trackball move-state handling when key bindings use modifiers - Fix rendering with very small viewport and SSAO enabled +- Fix `.getAllLoci` for structure representations with `structure.child` ## [v3.33.0] - 2023-04-02 diff --git a/src/mol-repr/structure/complex-representation.ts b/src/mol-repr/structure/complex-representation.ts index e959f9189..523ae0a84 100644 --- a/src/mol-repr/structure/complex-representation.ts +++ b/src/mol-repr/structure/complex-representation.ts @@ -77,7 +77,7 @@ export function ComplexRepresentation<P extends StructureParams>(label: string, } function getAllLoci() { - return [Structure.Loci(_structure.target)]; + return [Structure.Loci(_structure.child ?? _structure)]; } function mark(loci: Loci, action: MarkerAction) { diff --git a/src/mol-repr/structure/units-representation.ts b/src/mol-repr/structure/units-representation.ts index a286188a5..13845be97 100644 --- a/src/mol-repr/structure/units-representation.ts +++ b/src/mol-repr/structure/units-representation.ts @@ -195,7 +195,7 @@ export function UnitsRepresentation<P extends StructureParams>(label: string, ct } function getAllLoci() { - return [Structure.Loci(_structure.target)]; + return [Structure.Loci(_structure.child ?? _structure)]; } function mark(loci: Loci, action: MarkerAction) { -- GitLab