From 1b4b6f94357771854201bd4ae6b58f0a29dcc7d5 Mon Sep 17 00:00:00 2001 From: Alexander Rose <alexander.rose@weirdbyte.de> Date: Fri, 13 Nov 2020 20:51:27 -0800 Subject: [PATCH] add GlobalTextureSchema missing from renderables --- src/apps/viewer/index.html | 2 +- src/mol-gl/renderable/image.ts | 4 ++-- src/mol-gl/renderable/lines.ts | 4 ++-- src/mol-gl/renderable/points.ts | 4 ++-- src/mol-gl/renderable/spheres.ts | 4 ++-- src/mol-gl/renderable/text.ts | 4 ++-- src/mol-gl/renderable/texture-mesh.ts | 4 ++-- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/apps/viewer/index.html b/src/apps/viewer/index.html index e80c5bf46..9fe81219e 100644 --- a/src/apps/viewer/index.html +++ b/src/apps/viewer/index.html @@ -45,7 +45,7 @@ return decodeURIComponent(((window.location.search || '').match(r) || [])[1] || ''); } - var debugMode = true; // getParam('debug-mode', '[^&]+').trim() === '1'; + var debugMode = getParam('debug-mode', '[^&]+').trim() === '1'; if (debugMode) molstar.setDebugMode(debugMode, debugMode); var disableAntialiasing = getParam('disable-antialiasing', '[^&]+').trim() === '1'; diff --git a/src/mol-gl/renderable/image.ts b/src/mol-gl/renderable/image.ts index 0ba595cca..82c517213 100644 --- a/src/mol-gl/renderable/image.ts +++ b/src/mol-gl/renderable/image.ts @@ -7,7 +7,7 @@ import { Renderable, RenderableState, createRenderable } from '../renderable'; import { WebGLContext } from '../webgl/context'; import { createGraphicsRenderItem } from '../webgl/render-item'; -import { AttributeSpec, Values, GlobalUniformSchema, InternalSchema, TextureSpec, ElementsSpec, DefineSpec, InternalValues, BaseSchema, UniformSpec } from './schema'; +import { AttributeSpec, Values, GlobalUniformSchema, InternalSchema, TextureSpec, ElementsSpec, DefineSpec, InternalValues, BaseSchema, UniformSpec, GlobalTextureSchema } from './schema'; import { ImageShaderCode } from '../shader-code'; import { ValueCell } from '../../mol-util'; import { InterpolationTypeNames } from '../../mol-geo/geometry/image/image'; @@ -30,7 +30,7 @@ export type ImageSchema = typeof ImageSchema export type ImageValues = Values<ImageSchema> export function ImageRenderable(ctx: WebGLContext, id: number, values: ImageValues, state: RenderableState, materialId: number): Renderable<ImageValues> { - const schema = { ...GlobalUniformSchema, ...InternalSchema, ...ImageSchema }; + const schema = { ...GlobalUniformSchema, ...GlobalTextureSchema, ...InternalSchema, ...ImageSchema }; const internalValues: InternalValues = { uObjectId: ValueCell.create(id), }; diff --git a/src/mol-gl/renderable/lines.ts b/src/mol-gl/renderable/lines.ts index aa6c31bbb..a8272b29c 100644 --- a/src/mol-gl/renderable/lines.ts +++ b/src/mol-gl/renderable/lines.ts @@ -7,7 +7,7 @@ import { Renderable, RenderableState, createRenderable } from '../renderable'; import { WebGLContext } from '../webgl/context'; import { createGraphicsRenderItem } from '../webgl/render-item'; -import { GlobalUniformSchema, BaseSchema, AttributeSpec, DefineSpec, Values, InternalSchema, SizeSchema, ElementsSpec, InternalValues } from './schema'; +import { GlobalUniformSchema, BaseSchema, AttributeSpec, DefineSpec, Values, InternalSchema, SizeSchema, ElementsSpec, InternalValues, GlobalTextureSchema } from './schema'; import { ValueCell } from '../../mol-util'; import { LinesShaderCode } from '../shader-code'; @@ -26,7 +26,7 @@ export type LinesSchema = typeof LinesSchema export type LinesValues = Values<LinesSchema> export function LinesRenderable(ctx: WebGLContext, id: number, values: LinesValues, state: RenderableState, materialId: number): Renderable<LinesValues> { - const schema = { ...GlobalUniformSchema, ...InternalSchema, ...LinesSchema }; + const schema = { ...GlobalUniformSchema, ...GlobalTextureSchema, ...InternalSchema, ...LinesSchema }; const internalValues: InternalValues = { uObjectId: ValueCell.create(id), }; diff --git a/src/mol-gl/renderable/points.ts b/src/mol-gl/renderable/points.ts index 4f50b314e..a97b8bb59 100644 --- a/src/mol-gl/renderable/points.ts +++ b/src/mol-gl/renderable/points.ts @@ -7,7 +7,7 @@ import { Renderable, RenderableState, createRenderable } from '../renderable'; import { WebGLContext } from '../webgl/context'; import { createGraphicsRenderItem } from '../webgl/render-item'; -import { GlobalUniformSchema, BaseSchema, AttributeSpec, UniformSpec, DefineSpec, Values, InternalSchema, SizeSchema, InternalValues } from './schema'; +import { GlobalUniformSchema, BaseSchema, AttributeSpec, UniformSpec, DefineSpec, Values, InternalSchema, SizeSchema, InternalValues, GlobalTextureSchema } from './schema'; import { PointsShaderCode } from '../shader-code'; import { ValueCell } from '../../mol-util'; @@ -23,7 +23,7 @@ export type PointsSchema = typeof PointsSchema export type PointsValues = Values<PointsSchema> export function PointsRenderable(ctx: WebGLContext, id: number, values: PointsValues, state: RenderableState, materialId: number): Renderable<PointsValues> { - const schema = { ...GlobalUniformSchema, ...InternalSchema, ...PointsSchema }; + const schema = { ...GlobalUniformSchema, ...GlobalTextureSchema, ...InternalSchema, ...PointsSchema }; const internalValues: InternalValues = { uObjectId: ValueCell.create(id), }; diff --git a/src/mol-gl/renderable/spheres.ts b/src/mol-gl/renderable/spheres.ts index fbc5d0ec6..ebb602fbf 100644 --- a/src/mol-gl/renderable/spheres.ts +++ b/src/mol-gl/renderable/spheres.ts @@ -7,7 +7,7 @@ import { Renderable, RenderableState, createRenderable } from '../renderable'; import { WebGLContext } from '../webgl/context'; import { createGraphicsRenderItem } from '../webgl/render-item'; -import { GlobalUniformSchema, BaseSchema, AttributeSpec, Values, InternalSchema, SizeSchema, InternalValues, ElementsSpec, ValueSpec, DefineSpec } from './schema'; +import { GlobalUniformSchema, BaseSchema, AttributeSpec, Values, InternalSchema, SizeSchema, InternalValues, ElementsSpec, ValueSpec, DefineSpec, GlobalTextureSchema } from './schema'; import { SpheresShaderCode } from '../shader-code'; import { ValueCell } from '../../mol-util'; @@ -26,7 +26,7 @@ export type SpheresSchema = typeof SpheresSchema export type SpheresValues = Values<SpheresSchema> export function SpheresRenderable(ctx: WebGLContext, id: number, values: SpheresValues, state: RenderableState, materialId: number): Renderable<SpheresValues> { - const schema = { ...GlobalUniformSchema, ...InternalSchema, ...SpheresSchema }; + const schema = { ...GlobalUniformSchema, ...GlobalTextureSchema, ...InternalSchema, ...SpheresSchema }; const internalValues: InternalValues = { uObjectId: ValueCell.create(id), }; diff --git a/src/mol-gl/renderable/text.ts b/src/mol-gl/renderable/text.ts index a655bf144..a31ca9939 100644 --- a/src/mol-gl/renderable/text.ts +++ b/src/mol-gl/renderable/text.ts @@ -7,7 +7,7 @@ import { Renderable, RenderableState, createRenderable } from '../renderable'; import { WebGLContext } from '../webgl/context'; import { createGraphicsRenderItem } from '../webgl/render-item'; -import { GlobalUniformSchema, BaseSchema, AttributeSpec, UniformSpec, Values, InternalSchema, SizeSchema, InternalValues, TextureSpec, ElementsSpec, ValueSpec } from './schema'; +import { GlobalUniformSchema, BaseSchema, AttributeSpec, UniformSpec, Values, InternalSchema, SizeSchema, InternalValues, TextureSpec, ElementsSpec, ValueSpec, GlobalTextureSchema } from './schema'; import { TextShaderCode } from '../shader-code'; import { ValueCell } from '../../mol-util'; @@ -35,7 +35,7 @@ export type TextSchema = typeof TextSchema export type TextValues = Values<TextSchema> export function TextRenderable(ctx: WebGLContext, id: number, values: TextValues, state: RenderableState, materialId: number): Renderable<TextValues> { - const schema = { ...GlobalUniformSchema, ...InternalSchema, ...TextSchema }; + const schema = { ...GlobalUniformSchema, ...GlobalTextureSchema, ...InternalSchema, ...TextSchema }; const internalValues: InternalValues = { uObjectId: ValueCell.create(id), }; diff --git a/src/mol-gl/renderable/texture-mesh.ts b/src/mol-gl/renderable/texture-mesh.ts index a0d9be2ba..062936f5f 100644 --- a/src/mol-gl/renderable/texture-mesh.ts +++ b/src/mol-gl/renderable/texture-mesh.ts @@ -7,7 +7,7 @@ import { Renderable, RenderableState, createRenderable } from '../renderable'; import { WebGLContext } from '../webgl/context'; import { createGraphicsRenderItem } from '../webgl/render-item'; -import { GlobalUniformSchema, BaseSchema, DefineSpec, Values, InternalSchema, InternalValues, UniformSpec, TextureSpec } from './schema'; +import { GlobalUniformSchema, BaseSchema, DefineSpec, Values, InternalSchema, InternalValues, UniformSpec, TextureSpec, GlobalTextureSchema } from './schema'; import { MeshShaderCode } from '../shader-code'; import { ValueCell } from '../../mol-util'; @@ -28,7 +28,7 @@ export type TextureMeshSchema = typeof TextureMeshSchema export type TextureMeshValues = Values<TextureMeshSchema> export function TextureMeshRenderable(ctx: WebGLContext, id: number, values: TextureMeshValues, state: RenderableState, materialId: number): Renderable<TextureMeshValues> { - const schema = { ...GlobalUniformSchema, ...InternalSchema, ...TextureMeshSchema }; + const schema = { ...GlobalUniformSchema, ...GlobalTextureSchema, ...InternalSchema, ...TextureMeshSchema }; const internalValues: InternalValues = { uObjectId: ValueCell.create(id), }; -- GitLab