From 2b78d2dfe0ea781d93dea77572a8fbc687a0295b Mon Sep 17 00:00:00 2001 From: Alexander Rose <alex.rose@rcsb.org> Date: Wed, 28 Nov 2018 16:36:04 -0800 Subject: [PATCH] ignore data-loci in getBoundingSphere --- src/mol-model/loci.ts | 3 +++ .../behavior/dynamic/custom-props/rcsb/assembly-symmetry.ts | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mol-model/loci.ts b/src/mol-model/loci.ts index 8baa821d8..9dac68c63 100644 --- a/src/mol-model/loci.ts +++ b/src/mol-model/loci.ts @@ -118,6 +118,9 @@ namespace Loci { } else if (loci.kind === 'group-loci') { // TODO return void 0; + } else if (loci.kind === 'data-loci') { + // TODO maybe add loci.getBoundingSphere()??? + return void 0; } return Sphere3D.create(Vec3.clone(sphereHelper.center), Math.sqrt(sphereHelper.radiusSq)); diff --git a/src/mol-plugin/behavior/dynamic/custom-props/rcsb/assembly-symmetry.ts b/src/mol-plugin/behavior/dynamic/custom-props/rcsb/assembly-symmetry.ts index 5fac25309..3079bbcab 100644 --- a/src/mol-plugin/behavior/dynamic/custom-props/rcsb/assembly-symmetry.ts +++ b/src/mol-plugin/behavior/dynamic/custom-props/rcsb/assembly-symmetry.ts @@ -65,7 +65,6 @@ function labelAssemblySymmetryAxes(loci: Loci): string | undefined { labels.push(`Axis of order ${axis.order.value(v)} for ${symmetry.kind} ${symmetry.type.toLowerCase()} symmetry`) } }) - // labels.push(`Axis ${i + 1} for ${symmetry.kind} ${symmetry.type.toLowerCase()} symmetry`) return labels.length ? labels.join(', ') : undefined } return undefined -- GitLab