From 30e57ba0662295da40e610ac22deee4db441fada Mon Sep 17 00:00:00 2001
From: Alexander Rose <alex.rose@rcsb.org>
Date: Fri, 29 Jun 2018 15:26:37 -0700
Subject: [PATCH] bind elements buffer explicitely as it is not always recorded
in the VAO
---
src/mol-gl/webgl/render-item.ts | 4 +++-
src/mol-gl/webgl/vertex-array.ts | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mol-gl/webgl/render-item.ts b/src/mol-gl/webgl/render-item.ts
index 721d4720e..a9a8244b0 100644
--- a/src/mol-gl/webgl/render-item.ts
+++ b/src/mol-gl/webgl/render-item.ts
@@ -117,9 +117,11 @@ export function createRenderItem(ctx: Context, drawMode: DrawMode, shaderCode: S
program.setUniforms(uniformValues)
if (oesVertexArrayObject && vertexArray) {
oesVertexArrayObject.bindVertexArrayOES(vertexArray)
+ // TODO need to bind elements buffer explicitely since it is not always recorded in the VAO
+ if (elementsBuffer) elementsBuffer.bind()
} else {
- program.bindAttributes(attributeBuffers)
if (elementsBuffer) elementsBuffer.bind()
+ program.bindAttributes(attributeBuffers)
}
program.bindTextures(textures)
if (elementsBuffer) {
diff --git a/src/mol-gl/webgl/vertex-array.ts b/src/mol-gl/webgl/vertex-array.ts
index eef6217aa..aaf92f275 100644
--- a/src/mol-gl/webgl/vertex-array.ts
+++ b/src/mol-gl/webgl/vertex-array.ts
@@ -14,8 +14,8 @@ export function createVertexArray(ctx: Context, program: Program, attributeBuffe
if (oesVertexArrayObject) {
vertexArray = oesVertexArrayObject.createVertexArrayOES()
oesVertexArrayObject.bindVertexArrayOES(vertexArray)
- program.bindAttributes(attributeBuffers)
if (elementsBuffer) elementsBuffer.bind()
+ program.bindAttributes(attributeBuffers)
ctx.vaoCount += 1
oesVertexArrayObject.bindVertexArrayOES(null!)
}
--
GitLab