From 318863bd1875cdc48c891a12fa8299931058cbe7 Mon Sep 17 00:00:00 2001
From: Alexander Rose <alexander.rose@weirdbyte.de>
Date: Sun, 19 Jun 2022 19:05:58 -0700
Subject: [PATCH] fix missing aromatic bond display
- simplify code to always show when aromatic
---
CHANGELOG.md | 1 +
src/mol-repr/structure/visual/bond-intra-unit-cylinder.ts | 4 +---
src/mol-repr/structure/visual/bond-intra-unit-line.ts | 4 +---
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index be00b5b76..583b322dd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ Note that since we don't clearly distinguish between a public and private interf
- Fix missing ``super.componentWillUnmount()`` calls (@simeonborko)
- Fix missing ``uGroupCount`` update for visuals
+- Fix missing aromatic bond display
## [v3.9.0] - 2022-05-30
diff --git a/src/mol-repr/structure/visual/bond-intra-unit-cylinder.ts b/src/mol-repr/structure/visual/bond-intra-unit-cylinder.ts
index 013a584e1..ec837f48e 100644
--- a/src/mol-repr/structure/visual/bond-intra-unit-cylinder.ts
+++ b/src/mol-repr/structure/visual/bond-intra-unit-cylinder.ts
@@ -149,10 +149,8 @@ function getIntraUnitBondCylinderBuilderProps(unit: Unit.Atomic, structure: Stru
if (isBondType(f, BondType.Flag.Aromatic) || (arCount && !ignoreComputedAromatic)) {
if (arCount === 2) {
return LinkStyle.MirroredAromatic;
- } else if (arCount === 1 || deloTriplets?.getThirdElement(aI, bI)) {
- return LinkStyle.Aromatic;
} else {
- // case for bonds between two aromatic rings
+ return LinkStyle.Aromatic;
}
}
}
diff --git a/src/mol-repr/structure/visual/bond-intra-unit-line.ts b/src/mol-repr/structure/visual/bond-intra-unit-line.ts
index 351c190c3..68d1ca4f9 100644
--- a/src/mol-repr/structure/visual/bond-intra-unit-line.ts
+++ b/src/mol-repr/structure/visual/bond-intra-unit-line.ts
@@ -110,10 +110,8 @@ function createIntraUnitBondLines(ctx: VisualContext, unit: Unit, structure: Str
if (isBondType(f, BondType.Flag.Aromatic) || (arCount && !ignoreComputedAromatic)) {
if (arCount === 2) {
return LinkStyle.MirroredAromatic;
- } else if (arCount === 1 || deloTriplets?.getThirdElement(aI, bI)) {
- return LinkStyle.Aromatic;
} else {
- // case for bonds between two aromatic rings
+ return LinkStyle.Aromatic;
}
}
}
--
GitLab