From 50945493c18f393c7574758fb1d425973f818e7c Mon Sep 17 00:00:00 2001
From: David Sehnal <david.sehnal@gmail.com>
Date: Mon, 2 Nov 2020 20:58:08 +0100
Subject: [PATCH] fix canvas3d.setProps
---
src/mol-canvas3d/canvas3d.ts | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/mol-canvas3d/canvas3d.ts b/src/mol-canvas3d/canvas3d.ts
index 8b18eef98..d6b9264ae 100644
--- a/src/mol-canvas3d/canvas3d.ts
+++ b/src/mol-canvas3d/canvas3d.ts
@@ -129,7 +129,7 @@ interface Canvas3D {
const requestAnimationFrame = typeof window !== 'undefined'
? window.requestAnimationFrame
- : (f: (time: number) => void) => setImmediate(()=>f(Date.now())) as unknown as number;
+ : (f: (time: number) => void) => setImmediate(() => f(Date.now())) as unknown as number;
const cancelAnimationFrame = typeof window !== 'undefined'
? window.cancelAnimationFrame
: (handle: number) => clearImmediate(handle as unknown as NodeJS.Immediate);
@@ -607,12 +607,9 @@ namespace Canvas3D {
if (props.transparentBackground !== undefined) p.transparentBackground = props.transparentBackground;
if (props.viewport !== undefined) {
const doNotUpdate = p.viewport === props.viewport ||
- (p.viewport.name && p.viewport.name && shallowEqual(p.viewport.params, p.viewport.params));
+ (p.viewport.name === props.viewport.name && shallowEqual(p.viewport.params, props.viewport.params));
if (!doNotUpdate) {
- // clear old viewport
- renderer.setViewport(x, y, width, height);
- renderer.clear(p.transparentBackground);
p.viewport = props.viewport;
updateViewport();
syncViewport();
--
GitLab