From 5ae037797fac800f3e03fbde8d7e16a91018a3b5 Mon Sep 17 00:00:00 2001
From: David Sehnal <david.sehnal@gmail.com>
Date: Sat, 24 Nov 2018 21:25:14 +0100
Subject: [PATCH] mol-state: fix null obj handling in update

---
 src/mol-state/state.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mol-state/state.ts b/src/mol-state/state.ts
index 8286db855..5c74ca8ca 100644
--- a/src/mol-state/state.ts
+++ b/src/mol-state/state.ts
@@ -311,11 +311,12 @@ function findUpdateRoots(cells: Map<Transform.Ref, StateObjectCell>, tree: State
 
 function findUpdateRootsVisitor(n: Transform, _: any, s: { roots: Ref[], cells: Map<Ref, StateObjectCell> }) {
     const cell = s.cells.get(n.ref);
-    if (cell && cell.obj === StateObject.Null) return false;
     if (!cell || cell.version !== n.version || cell.status === 'error') {
         s.roots.push(n.ref);
         return false;
     }
+    // nothing below a Null object can be an update root
+    if (cell && cell.obj === StateObject.Null) return false;
     return true;
 }
 
-- 
GitLab