From 70fa85d7d4d0f350a032e6ae0bfd6e6fc82aab83 Mon Sep 17 00:00:00 2001
From: Alexander Rose <alexander.rose@weirdbyte.de>
Date: Fri, 28 May 2021 23:04:08 -0700
Subject: [PATCH] fix assembly-symmetry off option
- would not remove cage/axes visuals
---
docs/interesting-pdb-entries.md | 6 +++++-
src/extensions/rcsb/assembly-symmetry/prop.ts | 10 +++++++---
src/extensions/rcsb/assembly-symmetry/ui.tsx | 1 -
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/docs/interesting-pdb-entries.md b/docs/interesting-pdb-entries.md
index 9d1cd9946..329566992 100644
--- a/docs/interesting-pdb-entries.md
+++ b/docs/interesting-pdb-entries.md
@@ -28,4 +28,8 @@
* Multiple models with different sets of ligands or missing ligands (1J6T, 1VRC, 2ICY, 1O2F)
* Long linear sugar chain (4HG6)
* Anisotropic B-factors/Ellipsoids (1EJG)
-* NOS bridges (LYS-CSO in 7B0L, 6ZWJ, 6ZWH)
\ No newline at end of file
+* NOS bridges (LYS-CSO in 7B0L, 6ZWJ, 6ZWH)
+
+Assembly symmetries
+* 5M30 (Assembly 1, C3 local and pseudo)
+* 1RB8 (Assembly 1, I global)
\ No newline at end of file
diff --git a/src/extensions/rcsb/assembly-symmetry/prop.ts b/src/extensions/rcsb/assembly-symmetry/prop.ts
index 210a12761..f076ed6d6 100644
--- a/src/extensions/rcsb/assembly-symmetry/prop.ts
+++ b/src/extensions/rcsb/assembly-symmetry/prop.ts
@@ -124,16 +124,20 @@ export function getSymmetrySelectParam(structure?: Structure) {
if (structure) {
const assemblySymmetryData = AssemblySymmetryDataProvider.get(structure).value;
if (assemblySymmetryData) {
- const options: [number, string][] = [];
+ const options: [number, string][] = [
+ [-1, 'Off']
+ ];
for (let i = 0, il = assemblySymmetryData.length; i < il; ++i) {
const { symbol, kind } = assemblySymmetryData[i];
if (symbol !== 'C1') {
options.push([ i, `${i + 1}: ${symbol} ${kind}` ]);
}
}
- if (options.length) {
+ if (options.length > 1) {
param.options = options;
- param.defaultValue = options[0][0];
+ param.defaultValue = options[1][0];
+ } else {
+ options.length = 0;
}
}
}
diff --git a/src/extensions/rcsb/assembly-symmetry/ui.tsx b/src/extensions/rcsb/assembly-symmetry/ui.tsx
index 664ca9adc..bcb4a1b9a 100644
--- a/src/extensions/rcsb/assembly-symmetry/ui.tsx
+++ b/src/extensions/rcsb/assembly-symmetry/ui.tsx
@@ -73,7 +73,6 @@ export class AssemblySymmetryControls extends CollapsableControls<{}, AssemblySy
const structure = this.pivot.cell.obj?.data;
const params = PD.clone(structure ? AssemblySymmetryProvider.getParams(structure) : AssemblySymmetryProvider.defaultParams);
params.serverUrl.isHidden = true;
- params.symmetryIndex.options = [[-1, 'Off'], ...params.symmetryIndex.options];
return params;
}
--
GitLab