From 82401b4d3da77c6881ac8c9183aa4512dc536d24 Mon Sep 17 00:00:00 2001
From: Alexander Rose <alexander.rose@weirdbyte.de>
Date: Mon, 11 Feb 2019 07:56:30 -0800
Subject: [PATCH] chache mappedcontrols
---
src/mol-plugin/ui/controls/parameters.tsx | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/mol-plugin/ui/controls/parameters.tsx b/src/mol-plugin/ui/controls/parameters.tsx
index 0674d2c1e..7d26c184c 100644
--- a/src/mol-plugin/ui/controls/parameters.tsx
+++ b/src/mol-plugin/ui/controls/parameters.tsx
@@ -410,16 +410,28 @@ export class GroupControl extends React.PureComponent<ParamProps<PD.Group<any>>,
}
export class MappedControl extends React.PureComponent<ParamProps<PD.Mapped<any>>> {
+ private valuesCache: { [name: string]: PD.Values<any> } = {}
+ private setValues(name: string, values: PD.Values<any>) {
+ this.valuesCache[name] = values
+ }
+ private getValues(name: string) {
+ if (name in this.valuesCache) {
+ return this.valuesCache[name]
+ } else {
+ return this.props.param.map(name).defaultValue
+ }
+ }
+
change(value: PD.Mapped<any>['defaultValue'] ) {
this.props.onChange({ name: this.props.name, param: this.props.param, value });
}
onChangeName: ParamOnChange = e => {
- // TODO: Cache values when changing types?
- this.change({ name: e.value, params: this.props.param.map(e.value).defaultValue });
+ this.change({ name: e.value, params: this.getValues(e.value) });
}
onChangeParam: ParamOnChange = e => {
+ this.setValues(this.props.value.name, e.value)
this.change({ name: this.props.value.name, params: e.value });
}
--
GitLab