From 8d411f77482438046ec296398fb297a03b8c4fc2 Mon Sep 17 00:00:00 2001
From: David Sehnal <david.sehnal@gmail.com>
Date: Wed, 20 Feb 2019 14:00:56 +0100
Subject: [PATCH] mol-plugin: param controls fix
---
src/mol-plugin/state/animation/built-in.ts | 2 +-
src/mol-plugin/ui/controls/parameters.tsx | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/mol-plugin/state/animation/built-in.ts b/src/mol-plugin/state/animation/built-in.ts
index d22b1bf84..86593b3f4 100644
--- a/src/mol-plugin/state/animation/built-in.ts
+++ b/src/mol-plugin/state/animation/built-in.ts
@@ -16,7 +16,7 @@ export const AnimateModelIndex = PluginStateAnimation.create({
display: { name: 'Animate Model Index' },
params: () => ({
mode: PD.MappedStatic('once', {
- once: PD.Group({ direction: PD.Select('forward', [['forward', 'Forward'], ['backward', 'Backward']]) }),
+ once: PD.Group({ direction: PD.Select('forward', [['forward', 'Forward'], ['backward', 'Backward']]) }, { isFlat: true }),
palindrome: PD.Group({ }),
loop: PD.Group({ }),
}, { options: [['once', 'Once'], ['palindrome', 'Palindrome'], ['loop', 'Loop']] }),
diff --git a/src/mol-plugin/ui/controls/parameters.tsx b/src/mol-plugin/ui/controls/parameters.tsx
index 03a22c1ab..868c44f16 100644
--- a/src/mol-plugin/ui/controls/parameters.tsx
+++ b/src/mol-plugin/ui/controls/parameters.tsx
@@ -436,6 +436,10 @@ export class GroupControl extends React.PureComponent<ParamProps<PD.Group<any>>,
render() {
const params = this.props.param.params;
+
+ // Do not show if there are no params.
+ if (Object.keys(params).length === 0) return null;
+
const label = this.props.param.label || camelCaseToWords(this.props.name);
const controls = <ParameterControls params={params} onChange={this.onChangeParam} values={this.props.value} onEnter={this.props.onEnter} isDisabled={this.props.isDisabled} />;
--
GitLab