From ae2314d76c28f80c83d1cfde00d86a6ddbeb7511 Mon Sep 17 00:00:00 2001
From: Alexander Rose <alexander.rose@weirdbyte.de>
Date: Sat, 21 Aug 2021 13:48:25 -0700
Subject: [PATCH] fix camera/bounding helper not showing up
---
CHANGELOG.md | 1 +
src/mol-geo/geometry/transform-data.ts | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9c2b3c34e..f6a93c73c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ Note that since we don't clearly distinguish between a public and private interf
- Smooth border of molecular-surface with ``includeParent`` enabled
- Hide ``includeParent`` option from gaussian-surface visuals (not particularly useful)
- Improved ``StructureElement.Loci.size`` performance (for marking large cellpack models)
+- Fix new ``TransformData`` issues (camera/bounding helper not showing up)
## [v2.2.2] - 2021-08-11
diff --git a/src/mol-geo/geometry/transform-data.ts b/src/mol-geo/geometry/transform-data.ts
index 743d359b2..0d0988faa 100644
--- a/src/mol-geo/geometry/transform-data.ts
+++ b/src/mol-geo/geometry/transform-data.ts
@@ -60,11 +60,8 @@ export function createTransform(transformArray: Float32Array, instanceCount: num
ValueCell.update(transformData.aInstance, fillSerial(aInstance, instanceCount));
ValueCell.update(transformData.hasReflection, hasReflection);
-
- updateTransformData(transformData);
- return transformData;
} else {
- return {
+ transformData = {
aTransform: ValueCell.create(new Float32Array(instanceCount * 16)),
matrix: ValueCell.create(Mat4.identity()),
transform: ValueCell.create(new Float32Array(transformArray)),
@@ -75,6 +72,9 @@ export function createTransform(transformArray: Float32Array, instanceCount: num
hasReflection: ValueCell.create(hasReflection),
};
}
+
+ updateTransformData(transformData);
+ return transformData;
}
const identityTransform = new Float32Array(16);
--
GitLab