From aedb03f668f68e2fa0eefa87475935a2d4327610 Mon Sep 17 00:00:00 2001
From: Alexander Rose <alex.rose@rcsb.org>
Date: Wed, 27 Jun 2018 15:19:39 -0700
Subject: [PATCH] comments, cleanup
---
src/apps/structure-info/model.ts | 1 -
src/mol-model/structure/model/model.ts | 5 +++--
.../structure/model/properties/utils/coarse-keys.ts | 1 +
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/apps/structure-info/model.ts b/src/apps/structure-info/model.ts
index 2cc19a456..17f1b6373 100644
--- a/src/apps/structure-info/model.ts
+++ b/src/apps/structure-info/model.ts
@@ -238,7 +238,6 @@ parser.addArgument(['--file', '-f'], { help: 'filename' });
parser.addArgument(['--models'], { help: 'print models info', action: 'storeTrue' });
parser.addArgument(['--seq'], { help: 'print sequence', action: 'storeTrue' });
-parser.addArgument(['--ihm'], { help: 'print IHM', action: 'storeTrue' });
parser.addArgument(['--units'], { help: 'print units', action: 'storeTrue' });
parser.addArgument(['--sym'], { help: 'print symmetry', action: 'storeTrue' });
parser.addArgument(['--rings'], { help: 'print rings', action: 'storeTrue' });
diff --git a/src/mol-model/structure/model/model.ts b/src/mol-model/structure/model/model.ts
index e83ed86d3..868f7e8a4 100644
--- a/src/mol-model/structure/model/model.ts
+++ b/src/mol-model/structure/model/model.ts
@@ -38,10 +38,11 @@ interface Model extends Readonly<{
atomicConformation: AtomicConformation,
properties: {
- // secondary structure provided by the input file
+ /** secondary structure provided by the input file */
readonly secondaryStructure: SecondaryStructure,
- // maps modified residue name to its parent
+ /** maps modified residue name to its parent */
readonly modifiedResidueNameMap: Map<string, string>,
+ /** maps asym ids to serial numbers that are unique per asym id */
readonly asymIdSerialMap: Map<string, number>
},
diff --git a/src/mol-model/structure/model/properties/utils/coarse-keys.ts b/src/mol-model/structure/model/properties/utils/coarse-keys.ts
index da591779c..8ea3f848c 100644
--- a/src/mol-model/structure/model/properties/utils/coarse-keys.ts
+++ b/src/mol-model/structure/model/properties/utils/coarse-keys.ts
@@ -31,6 +31,7 @@ function createLookUp(entities: Entities, chain: Map<number, Map<string, number>
if (!cm.has(c)) return -1;
return cm.get(c)!;
}
+ // TODO consider implementing as binary search
const findSequenceKey: CoarsedElementKeys['findSequenceKey'] = (e, c, s) => {
const eKey = getEntKey(e);
if (eKey < 0) return -1;
--
GitLab