From c41bd702e2bdc60c4a5d9c0911353b642a830bb1 Mon Sep 17 00:00:00 2001
From: Alexander Rose <alexander.rose@weirdbyte.de>
Date: Sun, 26 Jun 2022 17:25:14 -0700
Subject: [PATCH] remove superfluous shader varying
---
CHANGELOG.md | 2 ++
src/mol-gl/shader/chunks/assign-color-varying.glsl.ts | 2 --
src/mol-gl/shader/chunks/color-frag-params.glsl.ts | 1 -
src/mol-gl/shader/chunks/color-vert-params.glsl.ts | 1 -
4 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index dfdcb4559..f3109f8d5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,8 @@ Note that since we don't clearly distinguish between a public and private interf
## [Unreleased]
+- Fix superfluous shader varying
+
## [v3.10.1] - 2022-06-26
- Fix groupCount when updating TextureMesh-based visuals
diff --git a/src/mol-gl/shader/chunks/assign-color-varying.glsl.ts b/src/mol-gl/shader/chunks/assign-color-varying.glsl.ts
index c45016fcc..fa8ea04fb 100644
--- a/src/mol-gl/shader/chunks/assign-color-varying.glsl.ts
+++ b/src/mol-gl/shader/chunks/assign-color-varying.glsl.ts
@@ -72,8 +72,6 @@ export const assign_color_varying = `
#endif
#ifdef dTransparency
- vGroup = group;
-
#if defined(dTransparencyType_groupInstance)
vTransparency = readFromTexture(tTransparency, aInstance * float(uGroupCount) + group, uTransparencyTexDim).a;
#elif defined(dTransparencyType_vertexInstance)
diff --git a/src/mol-gl/shader/chunks/color-frag-params.glsl.ts b/src/mol-gl/shader/chunks/color-frag-params.glsl.ts
index 464a609ba..82d1601d2 100644
--- a/src/mol-gl/shader/chunks/color-frag-params.glsl.ts
+++ b/src/mol-gl/shader/chunks/color-frag-params.glsl.ts
@@ -47,7 +47,6 @@ uniform float uBumpiness;
#endif
#ifdef dTransparency
- varying float vGroup;
varying float vTransparency;
#endif
`;
\ No newline at end of file
diff --git a/src/mol-gl/shader/chunks/color-vert-params.glsl.ts b/src/mol-gl/shader/chunks/color-vert-params.glsl.ts
index 3d3ed1a3f..b57c66a9e 100644
--- a/src/mol-gl/shader/chunks/color-vert-params.glsl.ts
+++ b/src/mol-gl/shader/chunks/color-vert-params.glsl.ts
@@ -75,7 +75,6 @@ uniform float uBumpiness;
#endif
#ifdef dTransparency
- varying float vGroup;
#if defined(dTransparencyType_groupInstance) || defined(dTransparencyType_vertexInstance)
varying float vTransparency;
uniform vec2 uTransparencyTexDim;
--
GitLab