From da413cc9e6baea2ff8d0e6ecc46581a9e530ccf1 Mon Sep 17 00:00:00 2001 From: dsehnal <david.sehnal@gmail.com> Date: Fri, 10 Jun 2022 14:53:26 +0200 Subject: [PATCH] added missing super.componentWillUnmount --- CHANGELOG.md | 2 ++ src/extensions/geo-export/ui.tsx | 1 + src/extensions/mp4-export/ui.tsx | 1 + src/mol-plugin-ui/state/snapshots.tsx | 1 + 4 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 74d7618e0..d0fa95053 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ Note that since we don't clearly distinguish between a public and private interf ## [Unreleased] +- Fix missing ``super.componentWillUnmount()`` calls (@simeonborko) + ## [v3.9.0] - 2022-05-30 - Improve picking by using drawbuffers (when available) to reduce number of drawcalls diff --git a/src/extensions/geo-export/ui.tsx b/src/extensions/geo-export/ui.tsx index 45461b77a..837c59021 100644 --- a/src/extensions/geo-export/ui.tsx +++ b/src/extensions/geo-export/ui.tsx @@ -71,6 +71,7 @@ export class GeometryExporterUI extends CollapsableControls<{}, State> { } componentWillUnmount() { + super.componentWillUnmount(); this._controls?.dispose(); this._controls = void 0; } diff --git a/src/extensions/mp4-export/ui.tsx b/src/extensions/mp4-export/ui.tsx index 0dbcd35c4..910a1b498 100644 --- a/src/extensions/mp4-export/ui.tsx +++ b/src/extensions/mp4-export/ui.tsx @@ -102,6 +102,7 @@ export class Mp4EncoderUI extends CollapsableControls<{}, State> { } componentWillUnmount() { + super.componentWillUnmount(); this._controls?.dispose(); this._controls = void 0; } diff --git a/src/mol-plugin-ui/state/snapshots.tsx b/src/mol-plugin-ui/state/snapshots.tsx index 540c17a8d..6d8757b37 100644 --- a/src/mol-plugin-ui/state/snapshots.tsx +++ b/src/mol-plugin-ui/state/snapshots.tsx @@ -215,6 +215,7 @@ export class RemoteStateSnapshots extends PluginUIComponent< } componentWillUnmount() { + super.componentWillUnmount(); this._mounted = false; } -- GitLab