diff --git a/CHANGELOG.md b/CHANGELOG.md index efc8a33cddb54af0b8faa00ae4b62da15fcbcdc4..a57fcc8af8a39c345923ec40381ad7bf9823036f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ Note that since we don't clearly distinguish between a public and private interf ## [Unreleased] - Fix 'once' for animations of systems with many frames +- Better guard against issue (black fringes) with bumpiness in impostors ## [v3.26.0] - 2022-12-04 diff --git a/src/mol-gl/shader/chunks/apply-light-color.glsl.ts b/src/mol-gl/shader/chunks/apply-light-color.glsl.ts index bddbf634b013296a098601b85406adb334e5450e..ff2036d50cdc38547483552017dae5c90274bbcc 100644 --- a/src/mol-gl/shader/chunks/apply-light-color.glsl.ts +++ b/src/mol-gl/shader/chunks/apply-light-color.glsl.ts @@ -12,7 +12,7 @@ export const apply_light_color = ` gl_FragColor = material; #else #ifdef bumpEnabled - if (uBumpFrequency > 0.0 && uBumpAmplitude > 0.0) { + if (uBumpFrequency > 0.0 && uBumpAmplitude > 0.0 && bumpiness > 0.0) { normal = perturbNormal(-vViewPosition, normal, fbm(vModelPosition * uBumpFrequency), (uBumpAmplitude * bumpiness) / uBumpFrequency); } #endif