From f9841dd3df13935edca3931777ba8fa2ef32a72a Mon Sep 17 00:00:00 2001
From: Alexander Rose <alexander.rose@weirdbyte.de>
Date: Sat, 16 Jul 2022 13:02:04 -0700
Subject: [PATCH] improve CellPack's adjustStyle option
- disable colorMarker
- set component options
- enable marking w/o ghost
---
CHANGELOG.md | 1 +
src/extensions/cellpack/model.ts | 11 +++++++++++
2 files changed, 12 insertions(+)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8e61db992..ca07dd049 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ Note that since we don't clearly distinguish between a public and private interf
- Fix missing 'material' annotation for some uniforms, causing unnecessary uniform updates
- Remove use of ``isnan`` in impostor shaders, not needed and causing slowdown
- Avoid using ``flat`` qualifier in shaders, causing slowdown
+- Improve CellPack's ``adjustStyle`` option (disable ``colorMarker``, set component options, enable marking w/o ghost)
## [v3.11.0] - 2022-07-04
diff --git a/src/extensions/cellpack/model.ts b/src/extensions/cellpack/model.ts
index a9babdc05..80fb0b3d9 100644
--- a/src/extensions/cellpack/model.ts
+++ b/src/extensions/cellpack/model.ts
@@ -581,9 +581,20 @@ export const LoadCellPackModel = StateAction.build({
})(({ state, params }, ctx: PluginContext) => Task.create('CellPack Loader', async taskCtx => {
if (params.preset.adjustStyle) {
ctx.managers.interactivity.setProps({ granularity: 'chain' });
+ ctx.managers.structure.component.setOptions({
+ ... ctx.managers.structure.component.state.options,
+ visualQuality: 'custom',
+ ignoreLight: true,
+ showHydrogens: false,
+ });
ctx.canvas3d?.setProps({
multiSample: { mode: 'off' },
cameraClipping: { far: false },
+ renderer: { colorMarker: false },
+ marking: {
+ enabled: true,
+ ghostEdgeStrength: 1,
+ },
postprocessing: {
occlusion: {
name: 'on',
--
GitLab