Terraform linting

.tflint.hcl

+config {
+	call_module_type = "local"
+	force = false
+}
+
+plugin "terraform" {
+	enabled = true
+	preset	= "recommended"
+}

cesnet-mcc/terraform/vms.tf

@@ -25,9 +25,9 @@ resource "openstack_compute_secgroup_v2" "ping" {
   rule {
     from_port   = 128
     to_port     = 0
-    # initial installation (bug in terraform): ip_protocol = "icmp"
     ip_protocol = "ipv6-icmp"
     cidr        = "::/0"
+    # initial installation (bug in terraform): ip_protocol = "icmp"
   }
 }
 
@@ -102,7 +102,6 @@ data "openstack_compute_flavor_v2" "gpu-flavor" {
 resource "openstack_compute_instance_v2" "master" {
   name            = "k8s-${var.site_name}-master"
   image_id        = data.openstack_images_image_v2.ubuntu.id
-  # 4 cores 4 GB RAM
   flavor_id       = data.openstack_compute_flavor_v2.master-flavor.id
   security_groups = ["default", "all"]
   user_data       = file("cloud-init.yaml")

common/terraform/firewall.tf

@@ -20,10 +20,11 @@ resource "openstack_networking_secgroup_rule_v2" "ping" {
   ethertype         = strcontains(each.key, ":") ? "IPv6" : "IPv4"
   port_range_min    = strcontains(each.key, ":") ? 128 : 8
   port_range_max    = 0
-  # protocol          = strcontains(each.key, ":") ? "ipv6-icmp" : "icmp"
   protocol          = "icmp"
   remote_ip_prefix  = each.key
   security_group_id = openstack_networking_secgroup_v2.ping.id
+  # for update:
+  # protocol          = strcontains(each.key, ":") ? "ipv6-icmp" : "icmp"
 }
 
 resource "openstack_networking_secgroup_rule_v2" "ssh" {

common/terraform/versions.tf

@@ -3,9 +3,12 @@ provider "openstack" {
 
 terraform {
   required_providers {
-    local = "~> 2.0"
+    local = {
+      source  = "hashicorp/local"
+      version = "~> 2.0"
+    }
     openstack = {
-      source  = "terraform-provider-openstack/openstack",
+      source  = "terraform-provider-openstack/openstack"
       version = ">= 1.38.0"
     }
   }