Ansible linting

common/playbooks/backup.yaml

@@ -47,4 +47,5 @@
       environment:
         KUBECONFIG: /etc/kubernetes/admin.conf
         PATH: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin
+      changed_when: true
       when: true

common/playbooks/k8s.yaml

@@ -47,7 +47,11 @@
             dest: /etc/cron-apt/action.d/9-upgrade
             content: -q -q dist-upgrade
             mode: 0644
-    - name: Mails settings
+      rescue:
+        - name: Site install cron-apt fail
+          fail:
+            mag: "Site install cron-apt failed"
+    - name: Mail Settings
       vars:
         fip_hostname: "{{ lookup('dig', (groups['fip'][0], 'PTR') | join('/')) | regex_replace('\\.$', '') }}"
       block:
@@ -575,8 +579,7 @@
         name: ubuntu-drivers-common
         update_cache: true
     - name: Install Nvidia driver packages
-      shell: |-
-        ubuntu-drivers install
+      command: ubuntu-drivers install
       changed_when: true
     - name: Reboot GPU node
       reboot:
@@ -615,6 +618,7 @@
           when: true
         - name: Get GPU node hostnames
           shell: |-
+            set -o pipefail
             kubectl get nodes --no-headers -o custom-columns=NAME:.metadata.name | grep -- -gpu-
           register: gpu_nodes
           changed_when: false
@@ -626,8 +630,12 @@
         - name: Add required label to GPU nodes to create mig profiles
           vars:
             mig_profile: all-1g.12gb
-          shell: |-
+          command: |-
             kubectl label node {{ item }} nvidia.com/mig.config={{ mig_profile }} --overwrite
           loop: "{{ gpu_nodes.stdout_lines }}"
           changed_when: true
           when: true
+      rescue:
+        - name: GPU Setup Fail
+          fail:
+            msg: "GPU setup failed"

common/playbooks/notebooks.yaml

@@ -11,7 +11,7 @@
       when: "'jupyterhub' not in ansible_local.helm_repos | map(attribute='name') | list or
             'eginotebooks' not in ansible_local.helm_repos | map(attribute='name') | list"
     - name: Get latest helm charts
-      shell: |-
+      command: |-
         helm repo update
       changed_when: true
     - name: Get Secrets from Vault for notebooks

egi-devel/playbooks/binder.yaml

@@ -212,6 +212,7 @@
       environment:
         KUBECONFIG: /etc/kubernetes/admin.conf
         PATH: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin
+      changed_when: true
       when: true
 
 - name: Workaround for binder socket and bind-mount race-condition