Code quality improvements in executable files in bin project subdirectory.
Greatly improved code quality using pylint and pyflakes. All files now rank above 9 points with custom .pylintrc-bin file. Following exceptions were added to default pylint configuration: * line-too-long - I do not want to have calls to logging service spanning over multiple lines and distracting from code flow. I want them to be only single line, no matter how long, because it is not important. * bad-whitespace - I like to add additional whitespaces in places, where they should not be, mostly to align related items vertically, which in my opinion improves readability. * logging-format-interpolation - In Python3 I prefer string.format() to string % (args). Additionally the pattern for module name validation was altered, because of our executable file naming policy (added suppot for '-' and '.' characters in name). (Redmine issue: #3443)
Showing
- .pylintrc-bin 425 additions, 0 deletions.pylintrc-bin
- bin/mentat-backup.py 67 additions, 49 deletionsbin/mentat-backup.py
- bin/mentat-cleanup.py 65 additions, 52 deletionsbin/mentat-cleanup.py
- bin/mentat-controller.py 122 additions, 107 deletionsbin/mentat-controller.py
- bin/mentat-dbmngr.py 61 additions, 52 deletionsbin/mentat-dbmngr.py
- bin/mentat-ideagen.py 50 additions, 38 deletionsbin/mentat-ideagen.py
- bin/mentat-inspector.py 21 additions, 27 deletionsbin/mentat-inspector.py
- bin/mentat-netmngr.py 59 additions, 59 deletionsbin/mentat-netmngr.py
- bin/mentat-sampler.py 43 additions, 24 deletionsbin/mentat-sampler.py
- bin/mentat-storage.py 25 additions, 35 deletionsbin/mentat-storage.py
Loading
Please register or sign in to comment