Notification mails about new users for the group do not seem to go to group admin

Happened 8. 1. 2021 with ferusvi@zcu.cz on mentat-hub, where notification mail haven't reached group managers.

assigned to @Jan_Mach

By Pavel Kácha on 2024-12-26T14:07:13

added C-Dev-Core Done 0% P4 S-New T-Bug labels

changed milestone to %2.8

added Done 50% S-In Progress labels and removed Done 0% S-New labels

I have verified (sorry for the spam), that the mailing to group managers works when following conditions are met: group must have self management enabled, user must request group membership during registration. Information about mails being sent in now logged more verbosely into /var/mentat/log/mentat-hawat.py.log file.

We can make the "Requested group memberships:" field required in the registration form to prevent this from happening again, if that is desirable. Also we can remove the "self management enabled" requirement by discarding the managed column from groups table and simply always send information emails in case group has any managers set.

Should I do the aforementioned changes?

By Jan Mach on 2021-03-10T20:39:22

added Done 90% S-Feedback labels and removed Done 50% S-In Progress labels

Jan Mach wrote in https://gitlab.cesnet.cz/709/migrace/homeproj/mentat-project-05/mentat-ng/-/issues/7106#note_200294:

I have verified (sorry for the spam), that the mailing to group managers works when following conditions are met: group must have self management enabled, user must request group membership during registration. Information about mails being sent in now logged more verbosely into /var/mentat/log/mentat-hawat.py.log file.

Thanks! On the devel, or deployed on hub also?

We can make the "Requested group memberships:" field required in the registration form to prevent this from happening again, if that is desirable. Also we can remove the "self management enabled" requirement by discarding the managed column from groups table and simply always send information emails in case group has any managers set.

Should I do the aforementioned changes?

I'd NOT go for required field - sometimes it is desirable to have users, which are members of no group (707 developers, students, ...)

Discarding 'managed' column makes sense (if admin does not want to manage group, it does not have to be an admin). However, couldn't there be a clash with Žerdík's changes, which Rajmund is going to integrate (#6239)? If so, I'd wait with it.

By Pavel Kácha on 2021-03-11T13:32:55

Pavel Kácha wrote in https://gitlab.cesnet.cz/709/migrace/homeproj/mentat-project-05/mentat-ng/-/issues/7106#note_200295:

Jan Mach wrote in https://gitlab.cesnet.cz/709/migrace/homeproj/mentat-project-05/mentat-ng/-/issues/7106#note_200294:

I have verified (sorry for the spam), that the mailing to group managers works when following conditions are met: group must have self management enabled, user must request group membership during registration. Information about mails being sent in now logged more verbosely into /var/mentat/log/mentat-hawat.py.log file.

Thanks! On the devel, or deployed on hub also?

Only on mentat-alt. There were no major code changes, I have just added some log writes to be able to better verify the code flow. There are no code flow fixes.

We can make the "Requested group memberships:" field required in the registration form to prevent this from happening again, if that is desirable. Also we can remove the "self management enabled" requirement by discarding the managed column from groups table and simply always send information emails in case group has any managers set.

Should I do the aforementioned changes?

I'd NOT go for required field - sometimes it is desirable to have users, which are members of no group (707 developers, students, ...)

OK.

Discarding 'managed' column makes sense (if admin does not want to manage group, it does not have to be an admin). However, couldn't there be a clash with Žerdík's changes, which Rajmund is going to integrate (#6239)? If so, I'd wait with it.

No, there should not be any clashes. Žerdik`s changes are related to reporting settings contained mostly in reporting_settings table. This is a managed column in groups table, unrelated to reporting.

By Jan Mach on 2021-03-26T05:49:49

After the discussion we will proceed to remove managed column from groups table.

By Jan Mach on 2021-03-26T10:07:04

added S-In Progress label and removed S-Feedback label

changed milestone to %2.9

I have removed all uses of managed attribute from Group model. Ready to merge to devel branch for testing.

By Jan Mach on 2021-10-13T18:06:54

added Done 100% S-Feedback labels and removed Done 90% S-In Progress labels

Merged into devel.

By Rajmund Hruška on 2021-10-18T12:43:33

added S-In Review label and removed S-Feedback label

Marking as resolved. When you think it was tested for enough time, we can close. I have already deleted the branch, in case the fix is needed it will be better to do it directly in devel branch to save some time.

By Jan Mach on 2021-10-20T19:13:40

added S-Resolved label and removed S-In Review label

Changing back to in-review as it is at mentat-alt. (See Development_guidelines.)

By Pavel Kácha on 2021-10-21T07:29:37

added S-In Review label and removed S-Resolved label

Pavel Kácha wrote in https://gitlab.cesnet.cz/709/migrace/homeproj/mentat-project-05/mentat-ng/-/issues/7106#note_200302:

Changing back to in-review as it is at mentat-alt. (See Development_guidelines.)

Sorry, my bad.

By Jan Mach on 2021-10-22T07:55:03

In 7cdebc18 in the migration c2b4c2af6196_removed_groups_managed.py the managed column is set as not null. But there is no default value, so downgrading results in IntegrityError. I use downgrading quite often so I would appreciate if it was possible to downgrade.

By Rajmund Hruška on 2021-11-23T14:20:54

added S-Feedback label and removed S-In Review label

As it was discussed on 2021-12-01 meeting, I patched the downgrade, pushed the commit to devel and deployed the new version on mentat-alt.

By Rajmund Hruška on 2021-12-01T15:56:09

added S-In Review label and removed S-Feedback label

added S-Closed label and removed S-In Review label

closed