Change type of 'network' in 'networks' table to IP4R

Currently, the network is of type varchar. It would be nice to use some other type, such as iprange.

assigned to @rajmund_hruska

By Rajmund Hruška on 2024-12-26T14:07:46

added C-Dev-DB Done 0% P4 S-New T-Bug labels

changed milestone to %2.11

It's actually quite simple to change the type to ip4r.

The only issue is that according to ipranges 195.113.144.130/28 is a valid record whereas according to ip4r it is not. So searching for such addresses results in internal server error.

By Rajmund Hruška on 2022-09-26T11:44:14

added Done 60% S-In Progress T-Feature labels and removed Done 0% S-New T-Bug labels

As @ph noticed, timeline and events handle the aforementioned type of addresses, the phrase "Invalid address value xxx in search form." is written on the screen. I checked the code and the validation is not actually performed before the form is submitted, although it might seem like it is. In dispatch_request method, there is a try-catch block which handles the exception from the database. I don't like this approach and I would much rather check the value before posting request. I will probably go with high and low functions from ipranges and convert the value to range.

By Rajmund Hruška on 2022-10-03T12:10:40

Rajmund Hruska wrote in https://gitlab.cesnet.cz/709/migrace/homeproj/mentat-project-05/mentat-ng/-/issues/7603#note_200935:

As @ph noticed, timeline and events handle the aforementioned type of addresses, the phrase "Invalid address value xxx in search form." is written on the screen. I checked the code and the validation is not actually performed before the form is submitted, although it might seem like it is. In dispatch_request method, there is a try-catch block which handles the exception from the database. I don't like this approach and I would much rather check the value before posting request. I will probably go with high and low functions from ipranges and convert the value to range.

Fixed in dd0502fd.

So I think this is done.

By Rajmund Hruška on 2022-10-04T09:33:05

changed title from Consider migration of 'network' in 'networks' table to Change type of 'network' in 'networks' table to IP4R

By Rajmund Hruška on 2024-12-26T14:26:30

added Done 100% S-Resolved labels and removed Done 60% S-In Progress labels

Merged into devel.

By Rajmund Hruška on 2022-10-13T08:49:45

added S-In Review label and removed S-Resolved label

added S-Closed label and removed S-In Review label

closed