Skip to content
Snippets Groups Projects
Commit 8f8bde48 authored by Jan Mach's avatar Jan Mach
Browse files

Added sort_keys default to True into to_json method.

This is very usefull both for unit testing and for readability.
parent dffa2a26
No related branches found
No related tags found
No related merge requests found
...@@ -346,4 +346,5 @@ class IdeaBase(typedcols.TypedDict): ...@@ -346,4 +346,5 @@ class IdeaBase(typedcols.TypedDict):
raise ValueError(o) raise ValueError(o)
def to_json(self, *args, **kwargs): def to_json(self, *args, **kwargs):
kwargs.setdefault('sort_keys', True)
return json.dumps(self, default=self.json_default, *args, **kwargs) return json.dumps(self, default=self.json_default, *args, **kwargs)
...@@ -79,13 +79,13 @@ class TestIdea(unittest.TestCase): ...@@ -79,13 +79,13 @@ class TestIdea(unittest.TestCase):
def testLiteIdea(self): def testLiteIdea(self):
idea = lite.Idea(raw_idea) idea = lite.Idea(raw_idea)
orig = json.dumps(raw_idea, indent=4, sort_keys=True) orig = json.dumps(raw_idea, indent=4, sort_keys=True)
new = idea.to_json(indent=4, sort_keys=True) new = idea.to_json(indent=4)
self.assertEqual(orig, new, "\n".join([l for l in difflib.context_diff(orig.split("\n"), new.split("\n"))])) self.assertEqual(orig, new, "\n".join([l for l in difflib.context_diff(orig.split("\n"), new.split("\n"))]))
def testValidIdea(self): def testValidIdea(self):
idea = valid.Idea(raw_idea) idea = valid.Idea(raw_idea)
orig = json.dumps(raw_idea, indent=4, sort_keys=True) orig = json.dumps(raw_idea, indent=4, sort_keys=True)
new = idea.to_json(indent=4, sort_keys=True) new = idea.to_json(indent=4)
self.assertEqual(orig, new, "\n".join([l for l in difflib.context_diff(orig.split("\n"), new.split("\n"))])) self.assertEqual(orig, new, "\n".join([l for l in difflib.context_diff(orig.split("\n"), new.split("\n"))]))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment