Skip to content
Snippets Groups Projects
Rajmund Hruška's avatar
deleted branch devel at 713 / Warden / IPRanges
Pavel Kácha's avatar
accepted merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges
Pavel Kácha's avatar
pushed to branch master at 713 / Warden / IPRanges
Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 293e6559 · Fix subclass comparison logic in equality check
Pavel Kácha's avatar
commented on merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges

Note - second issubclass should have arguments switched.

Pavel Kácha's avatar
commented on merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges

I see... so it also solves this bug. 😄

Rajmund Hruška's avatar
commented on merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges

Anyway, I changed it based on your suggestion in 83231771.

Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 83231771 · Restrict objects for testing equality
Rajmund Hruška's avatar
commented on merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges

Comparing IP4 and IP6 is already possible prior to this patch:...

Pavel Kácha's avatar
commented on merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges

We could end up comparing apples and oranges (IP4 to IP6). Also, Range class does not know anything about IP*. However, there's no common ancestor ...

Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 7e4d41e8 · DEPLOY: Increased package version to '0.1.13' to build a new distri...
Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 5fbd688a · Set GitLab CI/CD image to Python 3.11
Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 8c94524b · Add equality with arbitrary objects
Rajmund Hruška's avatar
opened merge request !9 "Add equality with arbitrary objects" at 713 / Warden / IPRanges
Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 55f86ecb · Test equality with arbitrary objects
Rajmund Hruška's avatar
accepted merge request !8 "Update ipranges.py, .gitlab-ci.yml, README.rst" at 713 / Warden / IPRanges
Rajmund Hruška's avatar
pushed to branch master at 713 / Warden / IPRanges
Rajmund Hruška's avatar
opened merge request !8 "Update ipranges.py, .gitlab-ci.yml, README.rst" at 713 / Warden / IPRanges
Rajmund Hruška's avatar
pushed to branch devel at 713 / Warden / IPRanges
  • 543913cd · Update ipranges.py, .gitlab-ci.yml, README.rst
Rajmund Hruška's avatar
closed milestone %0.1.11 in 713 / Warden / IPRanges