Distinct exit statuses of command-line errors (thx bodik@cesnet.cz)

warden3/warden_server/warden_server.py

@@ -1536,23 +1536,23 @@ def modify_client(**kwargs):
         kwargs["hostname"] = kwargs["hostname"].lower()
         if not isValidHostname(kwargs["hostname"]):
             print >>sys.stderr, "Invalid hostname \"%s\"." % kwargs["hostname"]
-            return 254
+            return 253
 
     if kwargs["requestor"] is not None and not isValidEmail(kwargs["requestor"]):
         print >>sys.stderr, "Invalid requestor email \"%s\"." % kwargs["requestor"]
-        return 254
+        return 252
 
     if kwargs["id"] is not None and not isValidID(kwargs["id"]):
         print >>sys.stderr, "Invalid id \"%s\"." % kwargs["id"]
-        return 254
+        return 251
 
     for c in server.handler.db.get_clients():
         if kwargs["name"] is not None and kwargs["name"].lower()==c.name:
             print >>sys.stderr, "Clash with existing name: %s" % str(c)
-            return 254
+            return 250
         if kwargs["secret"] is not None and kwargs["secret"]==c.secret:
             print >>sys.stderr, "Clash with existing secret: %s" % str(c)
-            return 254
+            return 249
 
     newid = server.handler.db.add_modify_client(**kwargs)