Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Molstar
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Michal Malý
Molstar
Commits
0833cffe
Commit
0833cffe
authored
3 years ago
by
dsehnal
Browse files
Options
Downloads
Patches
Plain Diff
fix undefined value handling and update alised type
parent
a0a8ae88
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/mol-data/db/_spec/table.spec.ts
+14
-4
14 additions, 4 deletions
src/mol-data/db/_spec/table.spec.ts
src/mol-data/db/column.ts
+7
-12
7 additions, 12 deletions
src/mol-data/db/column.ts
with
21 additions
and
16 deletions
src/mol-data/db/_spec/table.spec.ts
+
14
−
4
View file @
0833cffe
...
@@ -62,15 +62,25 @@ describe('column', () => {
...
@@ -62,15 +62,25 @@ describe('column', () => {
});
});
describe
(
'
string column
'
,
()
=>
{
describe
(
'
string column
'
,
()
=>
{
const
arr
=
Column
.
ofArray
({
array
:
[
'
A
'
,
'
b
'
],
schema
:
Column
.
Schema
.
Str
({
lowerCase
:
true
})
});
const
xs
=
[
'
A
'
,
'
b
'
,
null
,
undefined
];
const
xsArr
=
xs
.
map
(
x
=>
x
??
''
);
const
xsLC
=
xs
.
map
(
x
=>
(
x
??
''
).
toLowerCase
());
const
arr
=
Column
.
ofArray
({
array
:
xs
as
any
,
schema
:
Column
.
Schema
.
str
});
const
arrLC
=
Column
.
ofArray
({
array
:
xs
as
any
,
schema
:
Column
.
Schema
.
Str
({
lowerCase
:
true
})
});
const
aliasedLC
=
Column
.
ofArray
({
array
:
xs
as
any
,
schema
:
Column
.
Schema
.
Aliased
<
'
a
'
|
'
b
'
>
(
Column
.
Schema
.
lowerCaseStr
)
});
it
(
'
value
'
,
()
=>
{
it
(
'
value
'
,
()
=>
{
expect
(
arr
.
value
(
0
)).
toBe
(
'
a
'
);
for
(
let
i
=
0
;
i
<
xs
.
length
;
i
++
)
{
expect
(
arr
.
value
(
1
)).
toBe
(
'
b
'
);
expect
(
arr
.
value
(
i
)).
toBe
(
xs
[
i
]
??
''
);
expect
(
arrLC
.
value
(
i
)).
toBe
(
xsLC
[
i
]
??
''
);
expect
(
aliasedLC
.
value
(
i
)).
toBe
(
xsLC
[
i
]);
}
});
});
it
(
'
array
'
,
()
=>
{
it
(
'
array
'
,
()
=>
{
expect
(
arr
.
toArray
()).
toEqual
([
'
a
'
,
'
b
'
]);
expect
(
arr
.
toArray
()).
toEqual
(
xsArr
);
expect
(
arrLC
.
toArray
()).
toEqual
(
xsLC
);
expect
(
aliasedLC
.
toArray
()).
toEqual
(
xsLC
);
});
});
});
});
...
...
This diff is collapsed.
Click to expand it.
src/mol-data/db/column.ts
+
7
−
12
View file @
0833cffe
...
@@ -41,6 +41,7 @@ namespace Column {
...
@@ -41,6 +41,7 @@ namespace Column {
export
type
List
<
T
extends
number
|
string
>
=
{
'
@type
'
:
'
list
'
,
T
:
T
[],
separator
:
string
,
itemParse
:
(
x
:
string
)
=>
T
}
&
Base
<
'
list
'
>
export
type
List
<
T
extends
number
|
string
>
=
{
'
@type
'
:
'
list
'
,
T
:
T
[],
separator
:
string
,
itemParse
:
(
x
:
string
)
=>
T
}
&
Base
<
'
list
'
>
export
const
str
:
Str
=
{
'
@type
'
:
'
str
'
,
T
:
''
,
valueType
:
'
str
'
,
lowerCase
:
false
};
export
const
str
:
Str
=
{
'
@type
'
:
'
str
'
,
T
:
''
,
valueType
:
'
str
'
,
lowerCase
:
false
};
export
const
lowerCaseStr
:
Str
=
{
'
@type
'
:
'
str
'
,
T
:
''
,
valueType
:
'
str
'
,
lowerCase
:
true
};
export
const
int
:
Int
=
{
'
@type
'
:
'
int
'
,
T
:
0
,
valueType
:
'
int
'
};
export
const
int
:
Int
=
{
'
@type
'
:
'
int
'
,
T
:
0
,
valueType
:
'
int
'
};
export
const
coord
:
Coordinate
=
{
'
@type
'
:
'
coord
'
,
T
:
0
,
valueType
:
'
float
'
};
export
const
coord
:
Coordinate
=
{
'
@type
'
:
'
coord
'
,
T
:
0
,
valueType
:
'
float
'
};
export
const
float
:
Float
=
{
'
@type
'
:
'
float
'
,
T
:
0
,
valueType
:
'
float
'
};
export
const
float
:
Float
=
{
'
@type
'
:
'
float
'
,
T
:
0
,
valueType
:
'
float
'
};
...
@@ -52,14 +53,7 @@ namespace Column {
...
@@ -52,14 +53,7 @@ namespace Column {
export
function
Vector
(
dim
:
number
,
baseType
:
Int
|
Float
=
float
):
Tensor
{
return
Tensor
(
Tensors
.
Vector
(
dim
,
baseType
[
'
@type
'
]
===
'
int
'
?
Int32Array
:
Float64Array
),
baseType
);
}
export
function
Vector
(
dim
:
number
,
baseType
:
Int
|
Float
=
float
):
Tensor
{
return
Tensor
(
Tensors
.
Vector
(
dim
,
baseType
[
'
@type
'
]
===
'
int
'
?
Int32Array
:
Float64Array
),
baseType
);
}
export
function
Matrix
(
rows
:
number
,
cols
:
number
,
baseType
:
Int
|
Float
=
float
):
Tensor
{
return
Tensor
(
Tensors
.
ColumnMajorMatrix
(
rows
,
cols
,
baseType
[
'
@type
'
]
===
'
int
'
?
Int32Array
:
Float64Array
),
baseType
);
}
export
function
Matrix
(
rows
:
number
,
cols
:
number
,
baseType
:
Int
|
Float
=
float
):
Tensor
{
return
Tensor
(
Tensors
.
ColumnMajorMatrix
(
rows
,
cols
,
baseType
[
'
@type
'
]
===
'
int
'
?
Int32Array
:
Float64Array
),
baseType
);
}
export
function
Aliased
<
T
>
(
t
:
Str
|
Int
,
options
?:
{
defaultValue
?:
T
,
lowerCase
?:
boolean
}):
Aliased
<
T
>
{
export
function
Aliased
<
T
>
(
t
:
Str
|
Int
):
Aliased
<
T
>
{
if
(
options
)
{
if
(
t
.
valueType
===
'
str
'
)
{
return
Str
(
options
as
any
)
as
any
as
Aliased
<
T
>
;
}
else
if
(
typeof
options
?.
defaultValue
===
'
number
'
)
{
return
Int
(
options
.
defaultValue
as
any
)
as
any
as
Aliased
<
T
>
;
}
}
return
t
as
any
as
Aliased
<
T
>
;
return
t
as
any
as
Aliased
<
T
>
;
}
}
export
function
List
<
T
extends
number
|
string
>
(
separator
:
string
,
itemParse
:
(
x
:
string
)
=>
T
,
defaultValue
:
T
[]
=
[]):
List
<
T
>
{
export
function
List
<
T
extends
number
|
string
>
(
separator
:
string
,
itemParse
:
(
x
:
string
)
=>
T
,
defaultValue
:
T
[]
=
[]):
List
<
T
>
{
...
@@ -293,10 +287,11 @@ function lambdaColumn<T extends Column.Schema>({ value, valueKind, areValuesEqua
...
@@ -293,10 +287,11 @@ function lambdaColumn<T extends Column.Schema>({ value, valueKind, areValuesEqua
function
arrayColumn
<
T
extends
Column
.
Schema
>
({
array
,
schema
,
valueKind
}:
Column
.
ArraySpec
<
T
>
):
Column
<
T
[
'
T
'
]
>
{
function
arrayColumn
<
T
extends
Column
.
Schema
>
({
array
,
schema
,
valueKind
}:
Column
.
ArraySpec
<
T
>
):
Column
<
T
[
'
T
'
]
>
{
const
rowCount
=
array
.
length
;
const
rowCount
=
array
.
length
;
const
defaultValue
=
schema
.
T
;
const
value
:
Column
<
T
[
'
T
'
]
>
[
'
value
'
]
=
schema
.
valueType
===
'
str
'
const
value
:
Column
<
T
[
'
T
'
]
>
[
'
value
'
]
=
schema
.
valueType
===
'
str
'
?
(
schema
as
Column
.
Schema
.
Str
).
lowerCase
?
(
schema
as
Column
.
Schema
.
Str
).
lowerCase
?
row
=>
{
const
v
=
array
[
row
];
return
typeof
v
===
'
string
'
?
v
.
toLowerCase
()
:
`
${
v
}
`
.
toLowerCase
();
}
?
row
=>
{
const
v
=
array
[
row
];
return
typeof
v
===
'
string
'
?
v
.
toLowerCase
()
:
`
${
v
??
defaultValue
}
`
.
toLowerCase
();
}
:
row
=>
{
const
v
=
array
[
row
];
return
typeof
v
===
'
string
'
?
v
:
''
+
v
;
}
:
row
=>
{
const
v
=
array
[
row
];
return
typeof
v
===
'
string
'
?
v
:
`
${
v
??
defaultValue
}
`
;
}
:
row
=>
array
[
row
];
:
row
=>
array
[
row
];
const
isTyped
=
ColumnHelpers
.
isTypedArray
(
array
);
const
isTyped
=
ColumnHelpers
.
isTypedArray
(
array
);
...
@@ -314,7 +309,7 @@ function arrayColumn<T extends Column.Schema>({ array, schema, valueKind }: Colu
...
@@ -314,7 +309,7 @@ function arrayColumn<T extends Column.Schema>({ array, schema, valueKind }: Colu
const
ret
=
new
(
params
&&
typeof
params
.
array
!==
'
undefined
'
?
params
.
array
:
(
array
as
any
).
constructor
)(
end
-
start
)
as
any
;
const
ret
=
new
(
params
&&
typeof
params
.
array
!==
'
undefined
'
?
params
.
array
:
(
array
as
any
).
constructor
)(
end
-
start
)
as
any
;
for
(
let
i
=
0
,
_i
=
end
-
start
;
i
<
_i
;
i
++
)
{
for
(
let
i
=
0
,
_i
=
end
-
start
;
i
<
_i
;
i
++
)
{
const
v
=
array
[
start
+
i
];
const
v
=
array
[
start
+
i
];
ret
[
i
]
=
typeof
v
===
'
string
'
?
v
.
toLowerCase
()
:
`
${
v
}
`
.
toLowerCase
();
ret
[
i
]
=
typeof
v
===
'
string
'
?
v
.
toLowerCase
()
:
`
${
v
??
defaultValue
}
`
.
toLowerCase
();
}
}
return
ret
;
return
ret
;
}
}
...
@@ -323,7 +318,7 @@ function arrayColumn<T extends Column.Schema>({ array, schema, valueKind }: Colu
...
@@ -323,7 +318,7 @@ function arrayColumn<T extends Column.Schema>({ array, schema, valueKind }: Colu
const
ret
=
new
(
params
&&
typeof
params
.
array
!==
'
undefined
'
?
params
.
array
:
(
array
as
any
).
constructor
)(
end
-
start
)
as
any
;
const
ret
=
new
(
params
&&
typeof
params
.
array
!==
'
undefined
'
?
params
.
array
:
(
array
as
any
).
constructor
)(
end
-
start
)
as
any
;
for
(
let
i
=
0
,
_i
=
end
-
start
;
i
<
_i
;
i
++
)
{
for
(
let
i
=
0
,
_i
=
end
-
start
;
i
<
_i
;
i
++
)
{
const
v
=
array
[
start
+
i
];
const
v
=
array
[
start
+
i
];
ret
[
i
]
=
typeof
v
===
'
string
'
?
v
:
''
+
v
;
ret
[
i
]
=
typeof
v
===
'
string
'
?
v
:
`
${
v
??
defaultValue
}
`
;
}
}
return
ret
;
return
ret
;
}
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment