Skip to content
Snippets Groups Projects
Commit 43b693bc authored by Alexander Rose's avatar Alexander Rose
Browse files

better visual-quality defaults handling

parent ca13c576
No related branches found
No related tags found
No related merge requests found
...@@ -105,9 +105,9 @@ export interface QualityProps { ...@@ -105,9 +105,9 @@ export interface QualityProps {
export function getQualityProps(props: Partial<QualityProps>, structure?: Structure) { export function getQualityProps(props: Partial<QualityProps>, structure?: Structure) {
let quality = defaults(props.quality, 'auto' as VisualQuality) let quality = defaults(props.quality, 'auto' as VisualQuality)
let detail = 1 let detail = defaults(props.detail, 1)
let radialSegments = 12 let radialSegments = defaults(props.radialSegments, 12)
let linearSegments = 8 let linearSegments = defaults(props.linearSegments, 8)
if (quality === 'auto' && structure) { if (quality === 'auto' && structure) {
const score = structure.elementCount const score = structure.elementCount
...@@ -124,17 +124,17 @@ export function getQualityProps(props: Partial<QualityProps>, structure?: Struct ...@@ -124,17 +124,17 @@ export function getQualityProps(props: Partial<QualityProps>, structure?: Struct
switch (quality) { switch (quality) {
case 'highest': case 'highest':
detail = 2 detail = 3
radialSegments = 36 radialSegments = 36
linearSegments = 18 linearSegments = 18
break break
case 'high': case 'high':
detail = 1 detail = 2
radialSegments = 24 radialSegments = 24
linearSegments = 12 linearSegments = 12
break break
case 'medium': case 'medium':
detail = 0 detail = 1
radialSegments = 12 radialSegments = 12
linearSegments = 8 linearSegments = 8
break break
...@@ -149,8 +149,7 @@ export function getQualityProps(props: Partial<QualityProps>, structure?: Struct ...@@ -149,8 +149,7 @@ export function getQualityProps(props: Partial<QualityProps>, structure?: Struct
linearSegments = 2 linearSegments = 2
break break
case 'custom': case 'custom':
detail = defaults(props.detail, 1) // use defaults or given props as set above
radialSegments = defaults(props.radialSegments, 12)
break break
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment