Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Molstar
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Michal Malý
Molstar
Commits
f62a431e
Commit
f62a431e
authored
6 years ago
by
Alexander Rose
Browse files
Options
Downloads
Patches
Plain Diff
faster gl buffer deletion
parent
eecf0f31
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/mol-canvas3d/canvas3d.ts
+6
-1
6 additions, 1 deletion
src/mol-canvas3d/canvas3d.ts
src/mol-gl/webgl/buffer.ts
+0
-3
0 additions, 3 deletions
src/mol-gl/webgl/buffer.ts
with
6 additions
and
4 deletions
src/mol-canvas3d/canvas3d.ts
+
6
−
1
View file @
f62a431e
...
...
@@ -126,6 +126,7 @@ namespace Canvas3D {
let
pickDirty
=
true
let
isPicking
=
false
let
isUpdating
=
false
let
drawPending
=
false
let
lastRenderTime
=
-
1
...
...
@@ -182,7 +183,7 @@ namespace Canvas3D {
}
function
render
(
variant
:
RenderVariant
,
force
:
boolean
)
{
if
(
isPicking
)
return
false
if
(
isPicking
||
isUpdating
)
return
false
let
didRender
=
false
controls
.
update
()
...
...
@@ -285,6 +286,7 @@ namespace Canvas3D {
}
function
add
(
repr
:
Representation
.
Any
)
{
isUpdating
=
true
const
oldRO
=
reprRenderObjects
.
get
(
repr
)
const
newRO
=
new
Set
<
RenderObject
>
()
repr
.
renderObjects
.
forEach
(
o
=>
newRO
.
add
(
o
))
...
...
@@ -299,6 +301,7 @@ namespace Canvas3D {
reprCount
.
next
(
reprRenderObjects
.
size
)
boundingSphereHelper
.
update
()
scene
.
update
()
isUpdating
=
false
requestDraw
(
true
)
}
...
...
@@ -329,11 +332,13 @@ namespace Canvas3D {
}
const
renderObjects
=
reprRenderObjects
.
get
(
repr
)
if
(
renderObjects
)
{
isUpdating
=
true
renderObjects
.
forEach
(
o
=>
scene
.
remove
(
o
))
reprRenderObjects
.
delete
(
repr
)
reprCount
.
next
(
reprRenderObjects
.
size
)
boundingSphereHelper
.
update
()
scene
.
update
()
isUpdating
=
false
requestDraw
(
true
)
}
},
...
...
This diff is collapsed.
Click to expand it.
src/mol-gl/webgl/buffer.ts
+
0
−
3
View file @
f62a431e
...
...
@@ -142,9 +142,6 @@ export function createBuffer(ctx: WebGLContext, array: ArrayType, itemSize: Buff
destroy
:
()
=>
{
if
(
destroyed
)
return
gl
.
bindBuffer
(
_bufferType
,
_buffer
);
// set size to 1 before deleting
(
gl
as
WebGLRenderingContext
).
bufferData
(
_bufferType
,
1
,
_usageHint
)
// TODO remove cast when webgl2 types are fixed
gl
.
deleteBuffer
(
_buffer
)
destroyed
=
true
ctx
.
bufferCount
-=
1
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment