Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Molstar
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Michal Malý
Molstar
Commits
fb3accaa
Unverified
Commit
fb3accaa
authored
2 years ago
by
Alexander Rose
Committed by
GitHub
2 years ago
Browse files
Options
Downloads
Plain Diff
Merge pull request #528 from molstar/safari-surf-fix
wrap gl_VertexID in int()
parents
2ee0f3bf
b3e79544
No related branches found
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
CHANGELOG.md
+1
-1
1 addition, 1 deletion
CHANGELOG.md
src/mol-gl/shader/chunks/common-vert-params.glsl.ts
+3
-1
3 additions, 1 deletion
src/mol-gl/shader/chunks/common-vert-params.glsl.ts
src/mol-plugin/features.ts
+0
-4
0 additions, 4 deletions
src/mol-plugin/features.ts
with
4 additions
and
6 deletions
CHANGELOG.md
+
1
−
1
View file @
fb3accaa
...
...
@@ -17,7 +17,7 @@ Note that since we don't clearly distinguish between a public and private interf
-
Add support for download of gzipped files
-
Don't filter IndexPairBonds by element-based rules in MOL/SDF and MOL2 (without symmetry) models
-
Fix Glycam Saccharide Names used by default
-
Prefer WebGL1 for more Safari versions to avoid broken
GPU surfaces rendering
-
Fix
GPU surfaces rendering
in Safari with WebGL2
-
Add
``fov``
(Field of View) Canvas3D parameter
-
Add
``sceneRadiusFactor``
Canvas3D parameter
-
Add background pass (skybox, image, horizontal/radial gradient)
...
...
This diff is collapsed.
Click to expand it.
src/mol-gl/shader/chunks/common-vert-params.glsl.ts
+
3
−
1
View file @
fb3accaa
...
...
@@ -44,7 +44,9 @@ varying vec3 vModelPosition;
varying vec3 vViewPosition;
#if defined(noNonInstancedActiveAttribs)
#define VertexID gl_VertexID
// int() is needed for some Safari versions
// see https://bugs.webkit.org/show_bug.cgi?id=244152
#define VertexID int(gl_VertexID)
#else
attribute float aVertex;
#define VertexID int(aVertex)
...
...
This diff is collapsed.
Click to expand it.
src/mol-plugin/features.ts
+
0
−
4
View file @
fb3accaa
...
...
@@ -15,10 +15,6 @@ export const PluginFeatureDetection = {
'
Version/15.1 Safari
'
,
'
Version/15.2 Safari
'
,
'
Version/15.3 Safari
'
,
// the following 'only' break GPU surfaces
'
Version/15.4 Safari
'
,
'
Version/15.5 Safari
'
,
'
Version/16.0 Safari
'
,
];
if
(
unpportedSafariVersions
.
some
(
v
=>
navigator
.
userAgent
.
indexOf
(
v
)
>
0
))
{
return
true
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment