Skip to content
Snippets Groups Projects
Commit f6387fc0 authored by František Dvořák's avatar František Dvořák
Browse files

b2drop: disable storing secrets in the JupyterHub database

parent 086d2cba
No related branches found
No related tags found
No related merge requests found
...@@ -184,7 +184,6 @@ hub: ...@@ -184,7 +184,6 @@ hub:
await super(B2DropSpawner, self).pre_spawn_hook(spawner) await super(B2DropSpawner, self).pre_spawn_hook(spawner)
b2drop_user = self.user_options.get("b2drop-user", "") b2drop_user = self.user_options.get("b2drop-user", "")
b2drop_pwd = self.user_options.get("b2drop-pwd", "") b2drop_pwd = self.user_options.get("b2drop-pwd", "")
b2drop_remember = self.user_options.get("b2drop-remember", None)
if not (b2drop_user and b2drop_pwd): if not (b2drop_user and b2drop_pwd):
secret = await self.api.read_namespaced_secret(self.token_secret_name, self.namespace) secret = await self.api.read_namespaced_secret(self.token_secret_name, self.namespace)
if secret and secret.data: if secret and secret.data:
...@@ -217,16 +216,10 @@ hub: ...@@ -217,16 +216,10 @@ hub:
"volumeMounts": volume_mounts, "volumeMounts": volume_mounts,
} }
) )
if b2drop_remember:
await self._update_secret({"b2drop-user": b2drop_user,
"b2drop-pwd": b2drop_pwd})
else:
await self._update_secret({"b2drop-user": "", "b2drop-pwd": ""})
def options_from_form(self, formdata): def options_from_form(self, formdata):
data = super(B2DropSpawner, self)._options_from_form(formdata) data = super(B2DropSpawner, self)._options_from_form(formdata)
data.update({'b2drop-user': formdata.get('b2drop-user', [None])[0], data.update({'b2drop-user': formdata.get('b2drop-user', [None])[0],
'b2drop-remember': formdata.get('b2drop-remember', [None])[0],
'b2drop-pwd': formdata.get('b2drop-pwd', [None])[0]}) 'b2drop-pwd': formdata.get('b2drop-pwd', [None])[0]})
return data return data
...@@ -415,10 +408,6 @@ hub: ...@@ -415,10 +408,6 @@ hub:
<label for="b2drop-pwd" class="form-label">B2DROP app Password</label> <label for="b2drop-pwd" class="form-label">B2DROP app Password</label>
<input type="password" class="form-control" name="b2drop-pwd" id="b2drop-pwd" value="{{ b2drop_pwd }}"> <input type="password" class="form-control" name="b2drop-pwd" id="b2drop-pwd" value="{{ b2drop_pwd }}">
</div> </div>
<div class='form-group'>
<input type="checkbox" id="b2drop-remember" name="b2drop-remember" {%if b2drop_ready %}checked{% endif %}>
<label class="form-check-label" for="from-check-input">Remember B2DROP credentials</label>
</div>
</div> </div>
</div> </div>
</div> </div>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment