Skip to content
Snippets Groups Projects
Commit 3726f28e authored by Alexander Rose's avatar Alexander Rose
Browse files

defer calculation of more scene properties

parent ead25d6a
No related branches found
No related tags found
No related merge requests found
/** /**
* Copyright (c) 2018-2022 mol* contributors, licensed under MIT, See LICENSE file for more info. * Copyright (c) 2018-2023 mol* contributors, licensed under MIT, See LICENSE file for more info.
* *
* @author Alexander Rose <alexander.rose@weirdbyte.de> * @author Alexander Rose <alexander.rose@weirdbyte.de>
* @author David Sehnal <david.sehnal@gmail.com> * @author David Sehnal <david.sehnal@gmail.com>
...@@ -105,6 +105,10 @@ namespace Scene { ...@@ -105,6 +105,10 @@ namespace Scene {
let boundingSphereDirty = true; let boundingSphereDirty = true;
let boundingSphereVisibleDirty = true; let boundingSphereVisibleDirty = true;
let markerAverageDirty = true;
let opacityAverageDirty = true;
let hasOpaqueDirty = true;
let markerAverage = 0; let markerAverage = 0;
let opacityAverage = 0; let opacityAverage = 0;
let hasOpaque = false; let hasOpaque = false;
...@@ -165,9 +169,9 @@ namespace Scene { ...@@ -165,9 +169,9 @@ namespace Scene {
} }
renderables.sort(renderableSort); renderables.sort(renderableSort);
markerAverage = calculateMarkerAverage(); markerAverageDirty = true;
opacityAverage = calculateOpacityAverage(); opacityAverageDirty = true;
hasOpaque = calculateHasOpaque(); hasOpaqueDirty = true;
return true; return true;
} }
...@@ -189,9 +193,9 @@ namespace Scene { ...@@ -189,9 +193,9 @@ namespace Scene {
const newVisibleHash = computeVisibleHash(); const newVisibleHash = computeVisibleHash();
if (newVisibleHash !== visibleHash) { if (newVisibleHash !== visibleHash) {
boundingSphereVisibleDirty = true; boundingSphereVisibleDirty = true;
markerAverage = calculateMarkerAverage(); markerAverageDirty = true;
opacityAverage = calculateOpacityAverage(); opacityAverageDirty = true;
hasOpaque = calculateHasOpaque(); hasOpaqueDirty = true;
visibleHash = newVisibleHash; visibleHash = newVisibleHash;
return true; return true;
} else { } else {
...@@ -268,9 +272,9 @@ namespace Scene { ...@@ -268,9 +272,9 @@ namespace Scene {
} else { } else {
syncVisibility(); syncVisibility();
} }
markerAverage = calculateMarkerAverage(); markerAverageDirty = true;
opacityAverage = calculateOpacityAverage(); opacityAverageDirty = true;
hasOpaque = calculateHasOpaque(); hasOpaqueDirty = true;
}, },
add: (o: GraphicsRenderObject) => commitQueue.add(o), add: (o: GraphicsRenderObject) => commitQueue.add(o),
remove: (o: GraphicsRenderObject) => commitQueue.remove(o), remove: (o: GraphicsRenderObject) => commitQueue.remove(o),
...@@ -311,12 +315,24 @@ namespace Scene { ...@@ -311,12 +315,24 @@ namespace Scene {
return boundingSphereVisible; return boundingSphereVisible;
}, },
get markerAverage() { get markerAverage() {
if (markerAverageDirty) {
markerAverage = calculateMarkerAverage();
markerAverageDirty = true;
}
return markerAverage; return markerAverage;
}, },
get opacityAverage() { get opacityAverage() {
if (opacityAverageDirty) {
opacityAverage = calculateOpacityAverage();
opacityAverageDirty = true;
}
return opacityAverage; return opacityAverage;
}, },
get hasOpaque() { get hasOpaque() {
if (hasOpaqueDirty) {
hasOpaque = calculateHasOpaque();
hasOpaqueDirty = true;
}
return hasOpaque; return hasOpaque;
}, },
}; };
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment