Deprecation warnings

There are 2 parts of this issue:

1. Fix existing deprecation warnings
2. Automatically check and report deprecation warnings

assigned to @rajmund_hruska

By Rajmund Hruška on 2024-12-26T14:07:40

added C-Test Done 0% P4 S-In Progress T-Bug labels

changed milestone to %Backlog

Back Relation 'relates' from: 7583

Relation Relates - Bug 7583 Report feedback not working

By Rajmund Hruška on 2022-06-01T12:36:01

There is a bunch of these deprecation warnings:

/vagrant/lib/hawat/base.py:636: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
  self.config.get('ICONS').get(default_icon)
/vagrant/lib/hawat/view/__init__.py:1846: DeprecationWarning: 'jinja2.Markup' is deprecated and will be removed in Jinja 3.1. Import 'markupsafe.Markup' instead.
  flask.Markup(self.get_message_success(item = item, parent = parent)),

So, we are using Markup from flask which is deprecated. flask fixed this warning (and a bunch of other warnings) in version 2.0.0. We are using version 1.1.1, so I suggest moving to the latest version (which is 2.1.2).

Regarding the second part of this issue, I would go with the solution described at https://stackoverflow.com/questions/59680450/how-to-detect-compiler-warnings-in-gitlab-ci. It won't produce any emails but on GitLab it will be visible that there are some warnings.

By Rajmund Hruška on 2022-06-01T12:53:31

added S-Feedback label and removed S-In Progress label

added Done 10% S-In Progress labels and removed Done 0% S-Feedback labels

changed milestone to %2.10

I changed Flask and internal packages (Pynspect, Pyzenkit, Pydgets, Idea, TypedCols, IPRanges) to use the most up to date versions. Now the version is limited by the major version, so those packages should be regularly updated, when minor versions are released. (https://stackoverflow.com/questions/46601761/is-it-a-good-practice-to-upgrade-all-python-packages-in-production-to-their-late)

I added wtforms_sqlalchemy package to replace wtforms.ext.sqlalchemy which has deprecation warnings. (https://github.com/wtforms/wtforms-sqlalchemy)

I also fixed the broken/skipped tests (#7494), so now all of the existing tests should be executed and deprecation warnings are printed.

I didn't update the other packages (such as pytz or wtforms), as they didn't produce any deprecation warnings.

By Rajmund Hruška on 2022-07-25T12:48:49

added Done 100% S-Resolved labels and removed Done 10% S-In Progress labels

Also, regarding checking the deprecation warnings - the mechanism will be implemented in GitLab CI/CD with #7539 (closed).

By Rajmund Hruška on 2022-07-25T12:50:07

Merged into devel and deployed on mentat-alt.

By Rajmund Hruška on 2022-07-27T15:41:13

added S-In Review label and removed S-Resolved label

added S-Closed label and removed S-In Review label

closed